hauntd/yii2-vote

View on GitHub
widgets/BaseWidget.php

Summary

Maintainability
A
45 mins
Test Coverage

The class BaseWidget has 16 fields. Consider redesigning BaseWidget to keep the number of fields under 15.
Open

abstract class BaseWidget extends Widget
{
    use ModuleTrait;

    /**
Severity: Minor
Found in widgets/BaseWidget.php by phpmd

TooManyFields

Since: 0.1

Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

Example

class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

Source https://phpmd.org/rules/codesize.html#toomanyfields

Function isBehaviorIncluded has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function isBehaviorIncluded()
    {
        if (isset($this->_behaviorIncluded)) {
            return $this->_behaviorIncluded;
        }
Severity: Minor
Found in widgets/BaseWidget.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class '\hauntd\vote\models\VoteAggregate' in method 'initDefaults'.
Open

                VoteAggregate::findOne([
                    'entity' => $this->getModule()->encodeEntity($this->entity),
                    'target_id' => $this->targetId,
                ]);
Severity: Minor
Found in widgets/BaseWidget.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Yii' in method 'init'.
Open

            throw new InvalidParamException(Yii::t('vote', 'Entity and model must be set.'));
Severity: Minor
Found in widgets/BaseWidget.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The property $_behaviorIncluded is not named in camelCase.
Open

abstract class BaseWidget extends Widget
{
    use ModuleTrait;

    /**
Severity: Minor
Found in widgets/BaseWidget.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status