Sign upLogin

haxney/railskating

View on GitHub
Star

Showing 11 of 11 total issues

Method import_round has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def self.import_round(hash, event, se_hash, judge_hash)
    round = event.rounds.create(number: hash[:number],
                                final: hash[:final],
                                adjudicators: hash[:judges].map { |j| judge_hash[j] },
                                # Just assume that exactly the number recalled
Severity: Minor
Found in lib/results_scrapers/importer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_round has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.import_round(hash, event, se_hash, judge_hash)
    round = event.rounds.create(number: hash[:number],
                                final: hash[:final],
                                adjudicators: hash[:judges].map { |j| judge_hash[j] },
                                # Just assume that exactly the number recalled
Severity: Minor
Found in lib/results_scrapers/importer.rb - About 1 hr to fix

    Method rules_5_to_8 has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.rules_5_to_8(finalists, place_to_assign)
    majority = (finalists.first.cumulative_marks.last / 2).next
    max_place = finalists.first.cumulative_marks.count

    inner = lambda do |place, contenders|
    Severity: Minor
    Found in lib/scrutineering.rb - About 1 hr to fix

      Method scrape_event has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.scrape_event(doc)
    event = {}

    title = doc.css('body title').first.content
    md = /Event #([0-9]+): (.+?) (.+?) (.+)/.match(title)
      Severity: Minor
      Found in lib/results_scrapers/zsconcepts.rb - About 1 hr to fix

        Method rules_5_to_8 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.rules_5_to_8(finalists, place_to_assign)
    majority = (finalists.first.cumulative_marks.last / 2).next
    max_place = finalists.first.cumulative_marks.count

    inner = lambda do |place, contenders|
        Severity: Minor
        Found in lib/scrutineering.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method scrape_couples has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.scrape_couples(rows, dances, judges)
    rows.map do |row|
      couple = {}
      cols = row.children
      name_elem = cols.shift.content
        Severity: Minor
        Found in lib/results_scrapers/zsconcepts.rb - About 1 hr to fix

          Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(id, cum_marks, cum_sums, places, sum, as_single)
          Severity: Minor
          Found in lib/scrutineering.rb - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  lead = if no_name
               Constants::Users::UNKNOWN_LEAD
             else
               lead_team = Team.find_or_create_by(name: couple_hash[:lead_team])
               # Assume that only first name and last name are present. If more
            Severity: Minor
            Found in lib/results_scrapers/importer.rb and 1 other location - About 30 mins to fix
            lib/results_scrapers/importer.rb on lines 80..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  follow = if no_name
                 Constants::Users::UNKNOWN_FOLLOW
               else
                 follow_team = Team.find_or_create_by(name: couple_hash[:follow_team])
                 follow_names = couple_hash[:follow_name].split($;, 2)
            Severity: Minor
            Found in lib/results_scrapers/importer.rb and 1 other location - About 30 mins to fix
            lib/results_scrapers/importer.rb on lines 66..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method rule_10 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.rule_10(contenders, place)
    contenders.each { |lf| lf.rule ||= 10 }
    by_count = contenders.sort_by { |lf| cum_marks(lf, place) }.reverse
    by_count_max = cum_marks(by_count.first, place)
    highest_count = by_count.select { |lf| cum_marks(lf, place) == by_count_max }
            Severity: Minor
            Found in lib/scrutineering.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method recalled_couples has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def recalled_couples
    raise RoundFinalnessError, "cannot recall couples from final round" if self.final?
    return @recalled if @recalled

    num_marks =
            Severity: Minor
            Found in app/models/round.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language