Showing 9 of 11 total issues
Method import_round has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def self.import_round(hash, event, se_hash, judge_hash)
round = event.rounds.create(number: hash[:number],
final: hash[:final],
adjudicators: hash[:judges].map { |j| judge_hash[j] },
# Just assume that exactly the number recalled- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method import_round has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.import_round(hash, event, se_hash, judge_hash)
round = event.rounds.create(number: hash[:number],
final: hash[:final],
adjudicators: hash[:judges].map { |j| judge_hash[j] },
# Just assume that exactly the number recalledMethod rules_5_to_8 has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.rules_5_to_8(finalists, place_to_assign)
majority = (finalists.first.cumulative_marks.last / 2).next
max_place = finalists.first.cumulative_marks.count
inner = lambda do |place, contenders|Method scrape_event has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.scrape_event(doc)
event = {}
title = doc.css('body title').first.content
md = /Event #([0-9]+): (.+?) (.+?) (.+)/.match(title)Method rules_5_to_8 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def self.rules_5_to_8(finalists, place_to_assign)
majority = (finalists.first.cumulative_marks.last / 2).next
max_place = finalists.first.cumulative_marks.count
inner = lambda do |place, contenders|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method scrape_couples has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.scrape_couples(rows, dances, judges)
rows.map do |row|
couple = {}
cols = row.children
name_elem = cols.shift.contentMethod initialize has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(id, cum_marks, cum_sums, places, sum, as_single)Method rule_10 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.rule_10(contenders, place)
contenders.each { |lf| lf.rule ||= 10 }
by_count = contenders.sort_by { |lf| cum_marks(lf, place) }.reverse
by_count_max = cum_marks(by_count.first, place)
highest_count = by_count.select { |lf| cum_marks(lf, place) == by_count_max }- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method recalled_couples has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def recalled_couples
raise RoundFinalnessError, "cannot recall couples from final round" if self.final?
return @recalled if @recalled
num_marks =- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"