hdachev/fakeredis

File redis.test.js has 1041 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// This is a slightly modified version of the redis@0.10.1 test suite.
// I'll mark all modifications with /*MODIF*/ to keep track of what I change.

function requireLibUtil() { /*MODIF*/
    try {

Function SORT has 77 lines of code (exceeds 25 allowed). Consider refactoring.

Open

tests.SORT = function () {
    var name = "SORT";

    client.del('y');
    client.del('x');

Function detect_buffers has 53 lines of code (exceeds 25 allowed). Consider refactoring.

Open

tests.detect_buffers = function () {
    var name = "detect_buffers", detect_client = redis.createClient(null, null, {detect_buffers: true});

    detect_client.on("ready", function () {
        // single Buffer or String

Function SCAN has 51 lines of code (exceeds 25 allowed). Consider refactoring.

Open

tests.SCAN = function(){
    var name = 'SCAN';
    var resultArray = [];

    client.flushdb();

Function SINTER has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

tests.SINTER = function () {
    var name = "SINTER";

    client.del('sa');
    client.del('sb');

Function HMGET has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

tests.HMGET = function () {
    var key1 = "test hash 1", key2 = "test hash 2", key3 = 123456789, name = "HMGET";

    // redis-like hmset syntax
    client.HMSET(key1, "0123456789", "abcdefghij", "some manner of key", "a type of value", require_string("OK", name));

Function SUNIONSTORE has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

tests.SUNIONSTORE = function () {
    var name = "SUNIONSTORE";

    client.del('sa');
    client.del('sb');

TODO found

Open

// TODO - add test for HMSET with optional callbacks

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

    // MODIF TODO FIX

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

        // MODIF TODO FIX

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

// TODO - need a better way to test auth, maybe auto-config a local Redis server or something.

• Exclude checks
  • Disable engine
  • Disable check

TODO found

Open

    // TODO - sort by hash value

• Exclude checks
  • Disable engine
  • Disable check

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    client.MGET("mget keys 1", "mget keys 2", "mget keys 3", function (err, results) {
        assert.strictEqual(null, err, "result sent back unexpected error: " + err);
        assert.strictEqual(3, results.length, name);
        assert.strictEqual("mget val 1", results[0].toString(), name);
        assert.strictEqual("mget val 2", results[1].toString(), name);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    client.MGET(["mget keys 1", "mget keys 2", "mget keys 3"], function (err, results) {
        assert.strictEqual(null, err, "result sent back unexpected error: " + err);
        assert.strictEqual(3, results.length, name);
        assert.strictEqual("mget val 1", results[0].toString(), name);
        assert.strictEqual("mget val 2", results[1].toString(), name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.smembers("set0", function (err, res) {
        assert.strictEqual(res.length, 3);
        assert.ok(~res.indexOf("member3"));
        assert.ok(~res.indexOf("member4"));
        assert.ok(~res.indexOf("member5"));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.smembers("set1", function (err, res) {
        assert.strictEqual(res.length, 3);
        assert.ok(~res.indexOf("member0"));
        assert.ok(~res.indexOf("member1"));
        assert.ok(~res.indexOf("member2"));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.sinter('sb', 'sc', function (err, intersection) {
        if (err) {
            assert.fail(err, name);
        }
        assert.equal(intersection.length, 2, name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.sinter('sa', 'sb', function (err, intersection) {
        if (err) {
            assert.fail(err, name);
        }
        assert.equal(intersection.length, 2, name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client4.get(new Buffer("string key 1"), function (err, reply) {
        assert.strictEqual(null, err, name);
        assert.strictEqual(true, Buffer.isBuffer(reply), name);
        assert.strictEqual("<Buffer 73 74 72 69 6e 67 20 76 61 6c 75 65>", reply.inspect(), name);
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        detect_client.get(new Buffer("string key 1"), function (err, reply) {
            assert.strictEqual(null, err, name);
            assert.strictEqual(true, Buffer.isBuffer(reply), name);
            assert.strictEqual("<Buffer 73 74 72 69 6e 67 20 76 61 6c 75 65>", reply.inspect(), name);
        });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    client.HMGET(key1, "0123456789", "some manner of key", function (err, reply) {
        assert.strictEqual("abcdefghij", reply[0].toString(), name);
        assert.strictEqual("a type of value", reply[1].toString(), name);
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    client.HMGET(key2, "0123456789", "some manner of key", function (err, reply) {
        assert.strictEqual("abcdefghij", reply[0].toString(), name);
        assert.strictEqual("a type of value", reply[1].toString(), name);
    });

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    client.HMGET(key3, "0123456789", "some manner of key", function (err, reply) {
        assert.strictEqual("abcdefghij", reply[0].toString(), name);
        assert.strictEqual("a type of value", reply[1].toString(), name);
    });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.sort('y', 'asc', 'alpha', function (err, sorted) {
        if (err) {
            assert.fail(err, name);
        }
        assert.deepEqual(buffers_to_strings(sorted), ['a', 'b', 'c', 'd'], name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.sort('y', 'desc', 'alpha', function (err, sorted) {
        if (err) {
            assert.fail(err, name);
        }
        assert.deepEqual(buffers_to_strings(sorted), ['d', 'c', 'b', 'a'], name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.sort('x', 'desc', function (err, sorted) {
        if (err) {
            assert.fail(err, name);
        }
        assert.deepEqual(buffers_to_strings(sorted), [9, 4, 3, 2], name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    client.sort('x', 'asc', function (err, sorted) {
        if (err) {
            assert.fail(err, name);
        }
        assert.deepEqual(buffers_to_strings(sorted), [2, 3, 4, 9], name);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

tests.PUNSUB_EMPTY = function () {
  // test situation where punsubscribe reply[1] is null
  var name = "PUNSUB_EMPTY";
  client3.punsubscribe(); // punsubscribe from all so can test null
  client3.punsubscribe(); // reply[1] will be null

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

tests.UNSUB_EMPTY = function () {
  // test situation where unsubscribe reply[1] is null
  var name = "UNSUB_EMPTY";
  client3.unsubscribe(); // unsubscribe from all so can test null
  client3.unsubscribe(); // reply[1] will be null

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

bclient.on("error", function (err) {
    console.error("bclient: " + err.stack);
    process.exit();
});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

client3.on("error", function (err) {
    console.error("client3: " + err.stack);
    process.exit();
});

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

client2.on("error", function (err) {
    console.error("client2: " + err.stack);
    process.exit();
});

• Read up
  Read up