Sign upLogin

hdachev/fakeredis

View on GitHub
Star

Showing 133 of 133 total issues

Function Connection has a Cognitive Complexity of 288 (exceeds 5 allowed). Consider refactoring.
Open

exports.Connection = function(backend, minLatency, maxLatency) {
  var connection = this
    , db = 0

    , queue, watch, block
Severity: Minor
Found in lib/connection.js - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File backend.js has 1440 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";


// Error replies.
Severity: Major
Found in lib/backend.js - About 3 days to fix

    Function Backend has a Cognitive Complexity of 132 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.Backend = function () {
  var state
    , dbs = {}
    , delrev = {}
    , rev = 0
    Severity: Minor
    Found in lib/backend.js - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    prototype has 134 functions (exceeds 20 allowed). Consider refactoring.
    Open

    exports.Backend.prototype = {


  // Keys.
    Severity: Major
    Found in lib/backend.js - About 2 days to fix

      File redis.test.js has 1041 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // This is a slightly modified version of the redis@0.10.1 test suite.
// I'll mark all modifications with /*MODIF*/ to keep track of what I change.

function requireLibUtil() { /*MODIF*/
    try {
      Severity: Major
      Found in redis.test.js - About 2 days to fix

        Function Connection has 291 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.Connection = function(backend, minLatency, maxLatency) {
  var connection = this
    , db = 0

    , queue, watch, block
        Severity: Major
        Found in lib/connection.js - About 1 day to fix

          Function createClient has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.createClient = function(port, host, options) {
  if (arguments.length == 1 && typeof port == "object") { 
    options = port;
    if (options.port || options.host) {
      port = options.port;
          Severity: Minor
          Found in main.js - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Backend has 190 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.Backend = function () {
  var state
    , dbs = {}
    , delrev = {}
    , rev = 0
          Severity: Major
          Found in lib/backend.js - About 7 hrs to fix

            Function zOpStore has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
            Open

            , zOpStore: function (union, key, keys, weights, aggregate) {
    var K = this.getSetOrZsetKey(keys[0]);
    if (K instanceof ERROR) return K;

    var out = {}, member, x = 0, weight = (weights === null ? 1 : weights[0]);
            Severity: Minor
            Found in lib/backend.js - About 5 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function NORMAL has 137 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function NORMAL(client, entry) {
    var i, n, matches;


    // Transactions.
            Severity: Major
            Found in lib/connection.js - About 5 hrs to fix

              Function SORT has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
              Open

              , SORT: function () {
    var self = this, args = arr(arguments), n = args.length;
    if (!n) return new BAD_ARGS;

    // Parse.
              Severity: Minor
              Found in lib/backend.js - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  client.MGET(["mget keys 1", "mget keys 2", "mget keys 3"], function (err, results) {
        assert.strictEqual(null, err, "result sent back unexpected error: " + err);
        assert.strictEqual(3, results.length, name);
        assert.strictEqual("mget val 1", results[0].toString(), name);
        assert.strictEqual("mget val 2", results[1].toString(), name);
              Severity: Major
              Found in redis.test.js and 1 other location - About 3 hrs to fix
              redis.test.js on lines 1424..1430

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 114.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  client.MGET("mget keys 1", "mget keys 2", "mget keys 3", function (err, results) {
        assert.strictEqual(null, err, "result sent back unexpected error: " + err);
        assert.strictEqual(3, results.length, name);
        assert.strictEqual("mget val 1", results[0].toString(), name);
        assert.strictEqual("mget val 2", results[1].toString(), name);
              Severity: Major
              Found in redis.test.js and 1 other location - About 3 hrs to fix
              redis.test.js on lines 1431..1437

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 114.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function SORT has 98 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              , SORT: function () {
    var self = this, args = arr(arguments), n = args.length;
    if (!n) return new BAD_ARGS;

    // Parse.
              Severity: Major
              Found in lib/backend.js - About 3 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    client.smembers("set0", function (err, res) {
        assert.strictEqual(res.length, 3);
        assert.ok(~res.indexOf("member3"));
        assert.ok(~res.indexOf("member4"));
        assert.ok(~res.indexOf("member5"));
                Severity: Major
                Found in redis.test.js and 1 other location - About 3 hrs to fix
                redis.test.js on lines 1545..1551

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 105.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    client.smembers("set1", function (err, res) {
        assert.strictEqual(res.length, 3);
        assert.ok(~res.indexOf("member0"));
        assert.ok(~res.indexOf("member1"));
        assert.ok(~res.indexOf("member2"));
                Severity: Major
                Found in redis.test.js and 1 other location - About 3 hrs to fix
                redis.test.js on lines 1595..1601

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 105.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                File connection.js has 312 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                "use strict";


exports.Connection = function(backend, minLatency, maxLatency) {
  var connection = this
                Severity: Minor
                Found in lib/connection.js - About 3 hrs to fix

                  Function createClient has 86 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  exports.createClient = function(port, host, options) {
  if (arguments.length == 1 && typeof port == "object") { 
    options = port;
    if (options.port || options.host) {
      port = options.port;
                  Severity: Major
                  Found in main.js - About 3 hrs to fix

                    Function SET has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                    Open

                    , SET: function () {
    if (arguments.length < 2) return BAD_ARGS;
    var argc = 0;
    var key = arguments[argc++];
    var value = arguments[argc++];
                    Severity: Minor
                    Found in lib/backend.js - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function slice has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                    Open

                    var slice = function (arr, start, stop, asCount) {
  start = str2int(start);
  stop = str2int(stop);
  if (start instanceof ERROR) return start;
  if (stop instanceof ERROR) return stop;
                    Severity: Minor
                    Found in lib/backend.js - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language