Sign upLogin

heap-data-structure/specification

View on GitHub
Star

Showing 30 of 30 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function _increasekey(
    _test,
    length,
    heapname,
    makeHeap,
Severity: Major
Found in src/parts/increasekey.js and 1 other location - About 3 days to fix
src/parts/decreasekey.js on lines 5..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 520.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function _decreasekey(
    _test,
    length,
    heapname,
    makeHeap,
Severity: Major
Found in src/parts/decreasekey.js and 1 other location - About 3 days to fix
src/parts/increasekey.js on lines 5..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 520.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

DummyHeapWithoutReferences.prototype.merge = function (other) {
    this.array = this.array.concat(other.array).sort(this.compare);

    this.length += other.length;
};
Severity: Major
Found in src/adt/DummyHeapWithoutReferences.js and 1 other location - About 2 hrs to fix
src/adt/DummyHeap.js on lines 56..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

DummyHeap.prototype.merge = function (other) {
    this.array = this.array.concat(other.array).sort(this.compare);

    this.length += other.length;
};
Severity: Major
Found in src/adt/DummyHeap.js and 1 other location - About 2 hrs to fix
src/adt/DummyHeapWithoutReferences.js on lines 28..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        while (i--) {
            const x = Math.random();
            q.push(x);
            a.push(x);
            if (length) t.deepEqual(q.length, a.length);
Severity: Major
Found in src/parts/pushreference.js and 3 other locations - About 1 hr to fix
src/parts/merge.js on lines 27..32
src/parts/popreference.js on lines 21..26
src/parts/pushpop.js on lines 13..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        while (i--) {
            const x = Math.random();
            q.push(x);
            a.push(x);
            if (length) t.deepEqual(q.length, a.length);
Severity: Major
Found in src/parts/popreference.js and 3 other locations - About 1 hr to fix
src/parts/merge.js on lines 27..32
src/parts/pushpop.js on lines 13..18
src/parts/pushreference.js on lines 23..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        while (i--) {
            const x = Math.random();
            q.push(x);
            a.push(x);
            if (length) t.deepEqual(q.length, a.length);
Severity: Major
Found in src/parts/pushpop.js and 3 other locations - About 1 hr to fix
src/parts/merge.js on lines 27..32
src/parts/popreference.js on lines 21..26
src/parts/pushreference.js on lines 23..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        while (i--) {
            const x = Math.random();
            q1.push(x);
            a.push(x);
            if (length) t.deepEqual(q1.length, a.length);
Severity: Major
Found in src/parts/merge.js and 3 other locations - About 1 hr to fix
src/parts/popreference.js on lines 21..26
src/parts/pushpop.js on lines 13..18
src/parts/pushreference.js on lines 23..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _merge has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function _merge(
    _test,
    length,
    heapname,
    makeHeap,
Severity: Minor
Found in src/parts/merge.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    DummyHeap.prototype.pushreference = function (reference) {
    this.array.push(reference);

    this.array.sort(this.compare);
    Severity: Major
    Found in src/adt/DummyHeap.js and 1 other location - About 1 hr to fix
    src/adt/DummyHeapWithoutReferences.js on lines 20..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    DummyHeapWithoutReferences.prototype.push = function (value) {
    this.array.push(value);

    this.array.sort(this.compare);
    Severity: Major
    Found in src/adt/DummyHeapWithoutReferences.js and 1 other location - About 1 hr to fix
    src/adt/DummyHeap.js on lines 48..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function _update(_test, length, heapname, makeHeap, diffname, diff, n) {
    const title = `Heap update (${heapname}, ${diffname}, ${n})`;

    _test(title, (t) => {
        const q = makeHeap(diff);
    Severity: Minor
    Found in src/parts/update.js - About 1 hr to fix

      Function _del has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function _del(_test, length, heapname, makeHeap, diffname, diff, n) {
    const title = `Heap delete (${heapname}, ${diffname}, ${n})`;

    _test(title, (t) => {
        const q = makeHeap(diff);
      Severity: Minor
      Found in src/parts/delete.js - About 1 hr to fix

        Function _increasekey has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function _increasekey(
    _test,
    length,
    heapname,
    makeHeap,
        Severity: Minor
        Found in src/parts/increasekey.js - About 1 hr to fix

          Function _pushreference has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function _pushreference(
    _test,
    length,
    heapname,
    makeHeap,
          Severity: Minor
          Found in src/parts/pushreference.js - About 1 hr to fix

            Function _decreasekey has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function _decreasekey(
    _test,
    length,
    heapname,
    makeHeap,
            Severity: Minor
            Found in src/parts/decreasekey.js - About 1 hr to fix

              Function _merge has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  _test,
    length,
    heapname,
    makeHeap,
    diffname,
              Severity: Major
              Found in src/parts/merge.js - About 1 hr to fix

                Function _update has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                export function _update(_test, length, heapname, makeHeap, diffname, diff, n) {
                Severity: Major
                Found in src/parts/update.js - About 50 mins to fix

                  Function _pushreference has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      _test,
    length,
    heapname,
    makeHeap,
    diffname,
                  Severity: Major
                  Found in src/parts/pushreference.js - About 50 mins to fix

                    Function _head has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    export function _head(_test, length, heapname, makeHeap, diffname, diff, n) {
                    Severity: Major
                    Found in src/parts/head.js - About 50 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language