Sign upLogin

hefangshi/fis-project-analyzer

View on GitHub
Star

Showing 13 of 13 total issues

Function pageAnalyzer has 196 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var pageAnalyzer = function(project){
    var workingPage = {};
    var donePage = {};

    function getStaticResourceByDeps(selfID, deps){
Severity: Major
Found in lib/pageAnalyzer.js - About 7 hrs to fix

    Function pageAnalyzer has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

    var pageAnalyzer = function(project){
    var workingPage = {};
    var donePage = {};

    function getStaticResourceByDeps(selfID, deps){
    Severity: Minor
    Found in lib/pageAnalyzer.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function projectLoader has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var projectLoader = function (projectPath, options){
    var conf = null;
    var resPool = null;
    var pkgs = null;
    var uriResPool = null;
    Severity: Major
    Found in lib/projectLoader.js - About 3 hrs to fix

      Function getStaticResourceByDeps has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function getStaticResourceByDeps(selfID, deps){
        var analyzeCache = {};
        var staticSyncPool = [];
        var staticAsyncPool = [];
        var all = deps['widget'].concat(deps['extends']);
      Severity: Minor
      Found in lib/pageAnalyzer.js - About 2 hrs to fix

        Function getConfs has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function getConfs(){
        if (conf)
            return conf;
        resPool = {};
        uriResPool = {};
        Severity: Minor
        Found in lib/projectLoader.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      async.forEach(function(dep){
                var deps = getStaticDepsFromMapJson(dep);
                async = async.concat(deps.sync);
                async = async.concat(deps.async);
            });
          Severity: Major
          Found in lib/pageAnalyzer.js and 1 other location - About 1 hr to fix
          lib/pageAnalyzer.js on lines 43..47

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  all.forEach(function(id){
            var childDeps = getStaticDepsFromMapJson(id);
            staticSyncPool = staticSyncPool.concat(childDeps.sync);
            staticAsyncPool = staticAsyncPool.concat(childDeps.async);
        });
          Severity: Major
          Found in lib/pageAnalyzer.js and 1 other location - About 1 hr to fix
          lib/pageAnalyzer.js on lines 82..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function getCurrentDepsByContent has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function getCurrentDepsByContent(content, exclude){
        if (exclude instanceof Array == false){
            exclude = [exclude||""];
        }
        content = content.toString().replace(/\n|\s\s+/g," ").replace(commentRegex,'');
          Severity: Minor
          Found in lib/pageAnalyzer.js - About 1 hr to fix

            Function getPkgByResource has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function getPkgByResource(resource){
        var pkg = {
            'async':[],
            'sync':[]
        };
            Severity: Minor
            Found in lib/pageAnalyzer.js - About 1 hr to fix

              Function getStaticDepsFromMapJson has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      function getStaticDepsFromMapJson(id){
            if (!analyzeCache[id])
                analyzeCache[id] = true;
            else
                return {sync:[],async:[]};
              Severity: Minor
              Found in lib/pageAnalyzer.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        resource.sync.forEach(function(sync){
            var uri = getResourceUri(sync);
            uri && pkg.sync.push(uri);
        });
                Severity: Minor
                Found in lib/pageAnalyzer.js and 1 other location - About 50 mins to fix
                lib/pageAnalyzer.js on lines 104..107

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        resource.async.forEach(function(async){
            var uri = getResourceUri(async);
            uri && pkg.async.push(uri);
        });
                Severity: Minor
                Found in lib/pageAnalyzer.js and 1 other location - About 50 mins to fix
                lib/pageAnalyzer.js on lines 108..111

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function projectLoader has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                var projectLoader = function (projectPath, options){
    var conf = null;
    var resPool = null;
    var pkgs = null;
    var uriResPool = null;
                Severity: Minor
                Found in lib/projectLoader.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language