heiglandreas/JUnitDiff

View on GitHub

Showing 14 of 14 total issues

Function parseFile has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function parseFile($filename)
    {
        if (! is_readable($filename)) {
            throw new \UnexpectedValueException(sprintf(
                'File %s is not readable',
Severity: Minor
Found in src/JUnitParser.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $output->writeln([
            $this->getApplication()->getLongVersion(),
            '',
Severity: Major
Found in src/Command/DiffCommand.php - About 2 hrs to fix

    Method parseFile has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function parseFile($filename)
        {
            if (! is_readable($filename)) {
                throw new \UnexpectedValueException(sprintf(
                    'File %s is not readable',
    Severity: Major
    Found in src/JUnitParser.php - About 2 hrs to fix

      Method execute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function execute(InputInterface $input, OutputInterface $output)
          {
              $style = new DiffStyle($input, $output);
              $style->title($this->getApplication()->getLongVersion());
      
      
      Severity: Minor
      Found in src/Command/CompareCommand.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output)
            {
                $output->writeln([
                    $this->getApplication()->getLongVersion(),
                    '',
        Severity: Minor
        Found in src/Command/DiffCommand.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function write has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function write(MergeResult $mergeResult)
            {
                $mergeResult->sort();
        
                foreach ($mergeResult as $key => $value) {
        Severity: Minor
        Found in src/Writer/Standard.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The class CompareCommand has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
        Open

        class CompareCommand extends Command
        {
            protected function configure()
            {
                $this->setName('compare')
        Severity: Minor
        Found in src/Command/CompareCommand.php by phpmd

        CouplingBetweenObjects

        Since: 1.1.0

        A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

        Example

        class Foo {
            /**
             * @var \foo\bar\X
             */
            private $x = null;
        
            /**
             * @var \foo\bar\Y
             */
            private $y = null;
        
            /**
             * @var \foo\bar\Z
             */
            private $z = null;
        
            public function setFoo(\Foo $foo) {}
            public function setBar(\Bar $bar) {}
            public function setBaz(\Baz $baz) {}
        
            /**
             * @return \SplObjectStorage
             * @throws \OutOfRangeException
             * @throws \InvalidArgumentException
             * @throws \ErrorException
             */
            public function process(\Iterator $it) {}
        
            // ...
        }

        Source https://phpmd.org/rules/design.html#couplingbetweenobjects

        Missing class import via use statement (line '73', column '22').
        Open

                $xpath = new \DOMXPath($dom);
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '86', column '28').
        Open

                    $element = new \DOMNode();
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '63', column '20').
        Open

                $dom = new \DOMDocument(1.0, 'UTF-8');
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '58', column '23').
        Open

                    throw new \UnexpectedValueException(sprintf(
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '67', column '23').
        Open

                    throw new \UnexpectedValueException(sprintf(
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
            return new \stdClass();
        }

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        The method parseFile() has an NPath complexity of 220. The configured NPath complexity threshold is 200.
        Open

            public function parseFile($filename)
            {
                if (! is_readable($filename)) {
                    throw new \UnexpectedValueException(sprintf(
                        'File %s is not readable',
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method parseFile() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
        Open

            public function parseFile($filename)
            {
                if (! is_readable($filename)) {
                    throw new \UnexpectedValueException(sprintf(
                        'File %s is not readable',
        Severity: Minor
        Found in src/JUnitParser.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Severity
        Category
        Status
        Source
        Language