Sign upLogin

helium/helium-python

View on GitHub
Star

Showing 46 of 46 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def put(self, url, callback,
            params=None, json=None, headers=None):  # noqa: D102
        return self._http(callback, 'PUT', url,
Severity: Major
Found in helium/adapter/requests.py and 2 other locations - About 50 mins to fix
helium/adapter/requests.py on lines 182..184
helium/adapter/requests.py on lines 200..202

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def get(self, url, callback,
            params=None, json=None, headers=None):  # noqa: D102
        return self._http(callback, 'GET', url,
Severity: Major
Found in helium/adapter/requests.py and 2 other locations - About 50 mins to fix
helium/adapter/requests.py on lines 189..191
helium/adapter/requests.py on lines 200..202

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    def patch(self, url, callback,
              params=None, json=None, headers=None):  # noqa: D102
        return self._http(callback, 'PATCH', url,
Severity: Major
Found in helium/adapter/requests.py and 2 other locations - About 50 mins to fix
helium/adapter/requests.py on lines 182..184
helium/adapter/requests.py on lines 189..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function post has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def post(self, url, callback,
Severity: Minor
Found in helium/adapter/requests.py - About 45 mins to fix

    Function post has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def post(self, url, callback,
    Severity: Minor
    Found in helium/adapter/aiohttp.py - About 45 mins to fix

      Function to_one has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def to_one(dest_class, type=RelationType.DIRECT, resource_classes=None,
      Severity: Minor
      Found in helium/relations.py - About 45 mins to fix

        Function post has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def post(self, url, callback,
        Severity: Minor
        Found in helium/session.py - About 45 mins to fix

          Function to_many has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def to_many(dest_class, type=RelationType.DIRECT,
          Severity: Minor
          Found in helium/relations.py - About 45 mins to fix

            Function metadata has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def metadata():
    """Create a metadata method builder.

    Returns:
            Severity: Minor
            Found in helium/metadata.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _mk_one has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def _mk_one(cls, session,
                singleton=False, include=None, resource_classes=None):
        classes = resource_classes or [cls]
        registry = {clazz._resource_type(): clazz for clazz in classes}
            Severity: Minor
            Found in helium/resource.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function patch has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def patch(self, url, callback,
            Severity: Minor
            Found in helium/session.py - About 35 mins to fix

              Function live has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def live(self, session, url, resource_class, resource_args, params=None):  # noqa: D102
              Severity: Minor
              Found in helium/adapter/requests.py - About 35 mins to fix

                Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def get(self, url, callback,
                Severity: Minor
                Found in helium/adapter/aiohttp.py - About 35 mins to fix

                  Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def get(self, url, callback,
                  Severity: Minor
                  Found in helium/adapter/requests.py - About 35 mins to fix

                    Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def get(self, url, callback,
                    Severity: Minor
                    Found in helium/session.py - About 35 mins to fix

                      Function put has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def put(self, url, callback,
                      Severity: Minor
                      Found in helium/session.py - About 35 mins to fix

                        Function put has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def put(self, url, callback,
                        Severity: Minor
                        Found in helium/adapter/requests.py - About 35 mins to fix

                          Function create has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def create(cls, session, attributes=None,
                          Severity: Minor
                          Found in helium/label.py - About 35 mins to fix

                            Function patch has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def patch(self, url, callback,
                            Severity: Minor
                            Found in helium/adapter/requests.py - About 35 mins to fix

                              Function put has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def put(self, url, callback,
                              Severity: Minor
                              Found in helium/adapter/aiohttp.py - About 35 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language