lib/helium/collection.rb
Class Collection
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Collection
include Enumerable
attr_reader :filter_criteria
TODO found Open
Open
# TODO: could support something like label.sensors << new_sensor
- Exclude checks
Use ==
if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition. Open
Open
if existing_value = @filter_criteria[key]
- Read upRead up
- Exclude checks
This cop checks for assignments in the conditions of if/while/until.
Example:
# bad
if some_var = true
do_something
end
Example:
# good
if some_var == true
do_something
end