Sign upLogin

hello-gem/hello

View on GitHub
Star
lib/generators/hello/install/templates/onboarding/onboarding_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for continue is too high. [15.03/15]
Open

  def continue
    respond_to do |format|
      if update(params[:role])
        format.html { redirect_to root_path, notice: 'Welcome!' }
        format.json { render json: { user: current_user.as_json_web_api }, status: :ok }
Severity: Minor
Found in lib/generators/hello/install/templates/onboarding/onboarding_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Redundant return detected.
Open

      return true
Severity: Minor
Found in lib/generators/hello/install/templates/onboarding/onboarding_controller.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Put empty method definitions on a single line.
Open

  def index
  end
Severity: Minor
Found in lib/generators/hello/install/templates/onboarding/onboarding_controller.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Missing magic comment # frozen_string_literal: true.
Open

class OnboardingController < ApplicationController
Severity: Minor
Found in lib/generators/hello/install/templates/onboarding/onboarding_controller.rb by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Redundant return detected.
Open

      return true
Severity: Minor
Found in lib/generators/hello/install/templates/onboarding/onboarding_controller.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Redundant return detected.
Open

      return false
Severity: Minor
Found in lib/generators/hello/install/templates/onboarding/onboarding_controller.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

There are no issues that match your filters.

Category
Status