Sign upLogin

hellsan631/angular-fullPage.js

View on GitHub
Star

Showing 15 of 15 total issues

Function fullPage has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function fullPage($timeout) {
    var directive = {
      restrict: 'A',
      scope: {options: '='},
      link: link
Severity: Major
Found in angular-fullpage.js - About 3 hrs to fix

    Function fullPage has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function fullPage($timeout, $compile) {
    var directive = {
      restrict: 'A',
      scope: {options: '='},
      link: link
    Severity: Major
    Found in sample/app/directives/angular-fullPage.min.js - About 3 hrs to fix

      Function link has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function link(scope, element) {
      var pageIndex;
      var slideIndex;
      var afterRender;
      Severity: Major
      Found in sample/app/directives/angular-fullPage.min.js - About 2 hrs to fix

        Function link has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function link(scope, element) {
      var pageIndex;
      var slideIndex;
      var afterRender;
      var onLeave;
        Severity: Major
        Found in angular-fullpage.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  function afterAngularRender() {
          //We want to remove the HREF targets for navigation because they use hashbang
          //They still work without the hash though, so its all good.
          if (options && options.navigation) {
            $('#fp-nav').find('a').removeAttr('href');
          Severity: Major
          Found in angular-fullpage.js and 1 other location - About 2 hrs to fix
          sample/app/directives/angular-fullPage.min.js on lines 64..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  function afterAngularRender() {
          //We want to remove the HREF targets for navigation because they use hashbang
          //They still work without the hash though, so its all good.
          if (options && options.navigation) {
            $('#fp-nav').find('a').removeAttr('href');
          Severity: Major
          Found in sample/app/directives/angular-fullPage.min.js and 1 other location - About 2 hrs to fix
          angular-fullpage.js on lines 63..75

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function sanatizeOptions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                var sanatizeOptions = function(options) {
        var onLeave;
        var onSlideLeave;

        if (typeof options === 'object') {
          Severity: Minor
          Found in sample/app/directives/angular-fullPage.min.js - About 1 hr to fix

            Function MainController has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function MainController($state, $compile, $scope){

    var _this = this;

    this.mainOptions = {
            Severity: Minor
            Found in sample/app/views/main/main.controller.js - About 1 hr to fix

              Function sanatizeOptions has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    var sanatizeOptions = function(options) {
        options.afterRender = afterAngularRender;
        options.onLeave = onAngularLeave;
        options.onSlideLeave = onAngularSlideLeave;
              Severity: Minor
              Found in angular-fullpage.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        $(document).on('click', '[data-menuanchor]', function () {
          $.fn.fullpage.moveTo($(this).attr('data-menuanchor'));
        });
                Severity: Minor
                Found in angular-fullpage.js and 1 other location - About 50 mins to fix
                sample/app/directives/angular-fullPage.min.js on lines 98..100

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        $(document).on('click', '[data-menuanchor]', function () {
          $.fn.fullpage.moveTo($(this).attr('data-menuanchor'));
        });
                Severity: Minor
                Found in sample/app/directives/angular-fullPage.min.js and 1 other location - About 50 mins to fix
                angular-fullpage.js on lines 97..99

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      var destroyFullPage = function() {
        if ($.fn.fullpage.destroy) {
          $.fn.fullpage.destroy('all');
        }
      };
                Severity: Minor
                Found in sample/app/directives/angular-fullPage.min.js and 1 other location - About 45 mins to fix
                angular-fullpage.js on lines 52..56

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      var destroyFullPage = function() {
        if ($.fn.fullpage.destroy) {
          $.fn.fullpage.destroy('all');
        }
      };
                Severity: Minor
                Found in angular-fullpage.js and 1 other location - About 45 mins to fix
                sample/app/directives/angular-fullPage.min.js on lines 34..38

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function onAngularSlideLeave has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        function onAngularSlideLeave(anchorLink, page, slide, direction, next) {
                Severity: Minor
                Found in sample/app/directives/angular-fullPage.min.js - About 35 mins to fix

                  Function onAngularSlideLeave has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          function onAngularSlideLeave(anchorLink, page, slide, direction, next) {
                  Severity: Minor
                  Found in angular-fullpage.js - About 35 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language