Sign upLogin

helpyio/helpy

View on GitHub
Star
app/controllers/admin/users_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method user_params has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def user_params
    params.require(:user).permit(
      :profile_image,
      :name,
      :bio,
Severity: Minor
Found in app/controllers/admin/users_controller.rb - About 1 hr to fix

    Method update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    @user = User.find(params[:id])

    fetch_counts
    Severity: Minor
    Found in app/controllers/admin/users_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    @user = User.new(user_params)
    fetch_counts

    # Set the password if it is not provided
    Severity: Minor
    Found in app/controllers/admin/users_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

          # TODO: Refactor this to use an index method/view on the users model
    Severity: Minor
    Found in app/controllers/admin/users_controller.rb by fixme

    There are no issues that match your filters.

    Category
    Status