Sign upLogin

helpyio/helpy

View on GitHub
Star
app/controllers/api/v1/topics.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File topics.rb has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module API
  module V1
    class Topics < Grape::API

      before do
Severity: Minor
Found in app/controllers/api/v1/topics.rb - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            params do
          requires :name, type: String, desc: "The subject of the ticket"
          requires :body, type: String, desc: "The post body"
          optional :team_list, type: String, desc: "The group that this ticket is assigned to"
          optional :channel, type: String, desc: "The source channel the ticket was created from, Defaults to API if no value provided."
    Severity: Major
    Found in app/controllers/api/v1/topics.rb and 1 other location - About 2 hrs to fix
    app/controllers/api/v1/docs.rb on lines 67..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

              if current_user.is_restricted?
            ticket = Topic.where(id: permitted_params[:id]).all.tagged_with(current_user.team_list).first
          else
            ticket = Topic.where(id: permitted_params[:id]).first
    Severity: Minor
    Found in app/controllers/api/v1/topics.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/topics.rb on lines 140..143
    app/controllers/api/v1/topics.rb on lines 163..166
    app/controllers/api/v1/topics.rb on lines 216..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

              if current_user.is_restricted?
            ticket = Topic.where(id: permitted_params[:id]).all.tagged_with(current_user.team_list).first
          else
            ticket = Topic.where(id: permitted_params[:id]).first
    Severity: Minor
    Found in app/controllers/api/v1/topics.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/topics.rb on lines 163..166
    app/controllers/api/v1/topics.rb on lines 194..197
    app/controllers/api/v1/topics.rb on lines 216..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

              if current_user.is_restricted?
            ticket = Topic.where(id: permitted_params[:id]).all.tagged_with(current_user.team_list).first
          else
            ticket = Topic.where(id: permitted_params[:id]).first
    Severity: Minor
    Found in app/controllers/api/v1/topics.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/topics.rb on lines 140..143
    app/controllers/api/v1/topics.rb on lines 194..197
    app/controllers/api/v1/topics.rb on lines 216..219

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

              if current_user.is_restricted?
            ticket = Topic.where(id: permitted_params[:id]).all.tagged_with(current_user.team_list).first
          else
            ticket = Topic.where(id: permitted_params[:id]).first
    Severity: Minor
    Found in app/controllers/api/v1/topics.rb and 3 other locations - About 15 mins to fix
    app/controllers/api/v1/topics.rb on lines 140..143
    app/controllers/api/v1/topics.rb on lines 163..166
    app/controllers/api/v1/topics.rb on lines 194..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status