Sign upLogin

helpyio/helpy

View on GitHub
Star
app/models/user.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class User has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ActiveRecord::Base
  # Include default devise modules. Others available are:
  # :confirmable, :lockable, :timeoutable
  devise :invitable, :database_authenticatable, :registerable,
         :recoverable, :rememberable, :trackable, :validatable,
Severity: Minor
Found in app/models/user.rb - About 3 hrs to fix

    Method anonymize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def anonymize
    return if self.is_admin?

    # anonymize own attributes
    self.update!(
    Severity: Minor
    Found in app/models/user.rb - About 1 hr to fix

      Method find_for_oauth has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.find_for_oauth(auth)
    user = find_by(email: auth.info.email)
    if user
      user.tap do |u|
        u.provider = auth.provider
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

        # TODO: Will want to refactor this using .or when upgrading to Rails 5
      Severity: Minor
      Found in app/models/user.rb by fixme

      There are no issues that match your filters.

      Category
      Status