Sign upLogin

hendrikmaus/spas

View on GitHub
Star
src/Hook/Hook.php

Summary

Maintainability
A
0 mins
Test Coverage

The method contains has a boolean flag argument $forceLowercase, which is a certain sign of a Single Responsibility Principle violation.
Open

    protected function contains(string $needle, string $haystack, bool $forceLowercase = true) : bool
Severity: Minor
Found in src/Hook/Hook.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '75', column '36').
Open

            sprintf('%s: %s', (new \ReflectionClass(static::class))->getShortName(), $msg),
Severity: Minor
Found in src/Hook/Hook.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status