Sign upLogin

henkm/docdata

View on GitHub
Star

Showing 4 of 4 total issues

Method redirect_url has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def redirect_url
      url = {}
      
      base_url = Docdata::Config.return_url
      if Docdata::Config.test_mode
Severity: Minor
Found in lib/docdata/payment.rb - About 1 hr to fix

    Method redirect_url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def redirect_url
      url = {}
      
      base_url = Docdata::Config.return_url
      if Docdata::Config.test_mode
    Severity: Minor
    Found in lib/docdata/payment.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_line_items has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_line_items
      if @line_items.any?
        for line_item in @line_items
          if line_item.valid?
            # do nothing, this line_item seems okay
    Severity: Minor
    Found in lib/docdata/payment.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method amount_to_set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def amount_to_set
      #  if (report && Response.payment_node(report) && Response.payment_node(report)[:authorization] && Response.payment_node(report)[:authorization][:amount].present?)
      if (report && Response.payment_node(report) && Response.payment_node(report)[:authorization] && Response.payment_node(report)[:authorization][:amount].present?)
        if canceled
          return Response.payment_node(report)[:authorization][:amount].to_i
    Severity: Minor
    Found in lib/docdata/response.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language