Sign upLogin

henkm/prioticket

View on GitHub
Star

Showing 7 of 7 total issues

Method parse_json_value has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse_json_value(obj, k,v)
    unless v.nil?
      # "2018-03-24T00:00:00+01:00"
      is_integer    = !!Integer(v) rescue false
      is_float      = !!Float(v) rescue false
Severity: Minor
Found in lib/prioticket.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validated_booking_type_hash has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def validated_booking_type_hash
      
      # loops through all the booking details and raises error 
      # if from/to date_time are not present.
      if ticket
Severity: Minor
Found in lib/prioticket/booking.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_json_value has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.parse_json_value(obj, k,v)
    unless v.nil?
      # "2018-03-24T00:00:00+01:00"
      is_integer    = !!Integer(v) rescue false
      is_float      = !!Float(v) rescue false
Severity: Minor
Found in lib/prioticket.rb - About 1 hr to fix

    Method call has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.call(request_body, request_identifier, verbose=false)
      values   = request_body.to_json
      headers  = request_header(request_identifier)
      if verbose || PrioTicket::Config.verbose == true
        puts "Calling with:"
    Severity: Minor
    Found in lib/prioticket/api.rb - About 1 hr to fix

      Method call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.call(request_body, request_identifier, verbose=false)
      values   = request_body.to_json
      headers  = request_header(request_identifier)
      if verbose || PrioTicket::Config.verbose == true
        puts "Calling with:"
      Severity: Minor
      Found in lib/prioticket/api.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def self.get_status(distributor_id: nil, booking_reference: nil, distributor_reference: nil, identifier: nil)
      body = {
        request_type: "booking_status",
        data: {
          distributor_id: distributor_id,
      Severity: Minor
      Found in lib/prioticket/booking.rb and 1 other location - About 40 mins to fix
      lib/prioticket/booking.rb on lines 86..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def self.cancel(distributor_id: nil, booking_reference: nil, distributor_reference: nil, identifier: nil)
      body = {
        request_type: "cancel_booking",
        data: {
          distributor_id: distributor_id,
      Severity: Minor
      Found in lib/prioticket/booking.rb and 1 other location - About 40 mins to fix
      lib/prioticket/booking.rb on lines 104..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language