herereadthis/redwall

View on GitHub

Showing 63 of 63 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                                <li property="foaf:account" resource="#/me/pinterest/" typeof="foaf:OnlineAccount">
                                    <span property="foaf:accountServiceHomepage" resource="http://pinterest.com/"><span>Pinterest</span></span>
                                    <a rel="foaf:homepage" href="http://pinterest.com/herereadthis/"
                                       property="foaf:accountName">herereadthis</a>
                                </li>
Severity: Major
Found in app/views/Homepage/components/RetroFooter.js and 2 other locations - About 2 hrs to fix
app/views/Homepage/components/RetroFooter.js on lines 97..101
app/views/Homepage/components/RetroFooter.js on lines 102..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                                <li property="foaf:account" resource="#/me/github/" typeof="foaf:OnlineAccount">
                                    <span property="foaf:accountServiceHomepage" resource="https://github.com/"><span>GitHub</span></span>
                                    <a rel="foaf:homepage" href="https://github.com/herereadthis/redwall"
                                       property="foaf:accountName">herereadthis</a>
                                </li>
Severity: Major
Found in app/views/Homepage/components/RetroFooter.js and 2 other locations - About 2 hrs to fix
app/views/Homepage/components/RetroFooter.js on lines 97..101
app/views/Homepage/components/RetroFooter.js on lines 107..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                                <li property="foaf:account" resource="#/me/twitter/" typeof="foaf:OnlineAccount">
                                    <span property="foaf:accountServiceHomepage" resource="https://twitter.com/"><span>Twitter</span></span>
                                    <a rel="foaf:homepage" href="http://twitter.com/herereadthis"
                                       property="foaf:accountName">herereadthis</a>
                                </li>
Severity: Major
Found in app/views/Homepage/components/RetroFooter.js and 2 other locations - About 2 hrs to fix
app/views/Homepage/components/RetroFooter.js on lines 102..106
app/views/Homepage/components/RetroFooter.js on lines 107..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    static SessionStorageMethods = {
        set: (key, value) => {
            sessionStorage[key] = value;
        },
        get: (item) => {
Severity: Major
Found in app/AppConstants.js and 1 other location - About 2 hrs to fix
app/AppConstants.js on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    static LocalStorageMethods = {
        set: (key, value) => {
            localStorage[key] = value;
        },
        get: (item) => {
Severity: Major
Found in app/AppConstants.js and 1 other location - About 2 hrs to fix
app/AppConstants.js on lines 18..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function render has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        if (this.props.data === undefined) {
            return (
                <div>
                    <p>Loading...</p>
Severity: Major
Found in app/views/Homepage/views/NinetiesImage.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export default class WatchFlux extends Flux {
    
        constructor(flux) {
            super();
    
    
    Severity: Major
    Found in app/views/Watches/WatchFlux.js and 1 other location - About 2 hrs to fix
    app/views/Homepage/HomeFlux.js on lines 6..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export default class HomeFlux extends Flux {
    
        constructor(flux) {
            super();
    
    
    Severity: Major
    Found in app/views/Homepage/HomeFlux.js and 1 other location - About 2 hrs to fix
    app/views/Watches/WatchFlux.js on lines 6..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            else if (this.props.language === 'ru') {
                MMM = ['ianv', 'февр', 'март', 'апр', 'май', 'июнь', 'июль', 'авг',
                    'сент', 'окт', 'ноябрь', 'дек'];
                MMMM = ['январь', 'февраль', 'март', 'апрель', 'май', 'июнь',
                    'июль', 'август', 'сентябрь', 'октябрь', 'ноябрь', 'декабрь'];
    Severity: Major
    Found in app/components/DateRender.js and 2 other locations - About 2 hrs to fix
    app/components/DateRender.js on lines 30..72
    app/components/DateRender.js on lines 41..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            else if (this.props.language === 'es') {
                MMM = ['enero', 'feb', 'marzo', 'abr', 'mayo', 'jun', 'jul',
                    'agosto', 'set', 'oct', 'nov', 'dic'];
                MMMM = ['enero', 'febrero', 'marzo', 'abril', 'mayo', 'junio',
                    'julio', 'agosto', 'septiembre', 'octubre', 'noviembre',
    Severity: Major
    Found in app/components/DateRender.js and 2 other locations - About 2 hrs to fix
    app/components/DateRender.js on lines 30..72
    app/components/DateRender.js on lines 53..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (this.props.language === 'fr') {
                MMM = ['janv', 'févr', 'mars', 'avril', 'mai', 'juin', 'juil',
                    'août', 'sept', 'oct', 'nov', 'déc'];
                MMMM = ['janvier', 'février', 'mars', 'avril', 'mai', 'juin',
                    'juillet', 'août', 'septembre', 'octobre', 'novembre',
    Severity: Major
    Found in app/components/DateRender.js and 2 other locations - About 2 hrs to fix
    app/components/DateRender.js on lines 41..72
    app/components/DateRender.js on lines 53..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
            return (
                <article id="riley_fu" ref="rileyFu">
                    <h2 className="bellmaker_container">I swear, I actually know <a
                        href="/code/" title="Here, Read This Code">how to code</a>.
    Severity: Minor
    Found in app/views/Homepage/components/RileyFu.js - About 2 hrs to fix

      Function render has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
              var retroRulesStyle, goAway;
      
              retroRulesStyle = {
                  backgroundColor: '#000',
      Severity: Minor
      Found in app/views/Homepage/components/RetroRules.js - About 1 hr to fix

        Function popupContent has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            popupContent() {
                var foafLogoUrl = 'http://herereadthis.com/build/images/branding/' +
                    'herereadthis_logo.svg';
        
                return (
        Severity: Minor
        Found in app/views/Homepage/components/Banner.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (scrollContainerHeight < scrollBoxHeight) {
                      DomUtils.addClass(scrollBoxContainer, 'mac_os8_scrollable');
                      this.setState({
                          'scrollable': true
                      });
          Severity: Major
          Found in app/views/Homepage/views/NinetiesImageIndex.js and 1 other location - About 1 hr to fix
          app/views/Homepage/views/NinetiesImage.js on lines 83..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (scrollContainerHeight < scrollBoxHeight) {
                      DomUtils.addClass(scrollBoxContainer, 'mac_os8_scrollable');
                      this.setState({
                          'scrollable': true
                      });
          Severity: Major
          Found in app/views/Homepage/views/NinetiesImage.js and 1 other location - About 1 hr to fix
          app/views/Homepage/views/NinetiesImageIndex.js on lines 67..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function render has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              render() {
                  if (this.props.ninetiesImgSelection === undefined) {
                      return (
                          <div><p>Loading....</p></div>
                      );
          Severity: Minor
          Found in app/views/Homepage/components/NinetiesImgBox.js - About 1 hr to fix

            Function componentWillMount has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                componentWillMount() {
                    var MMM, MMMM, www, wwww;
                    // French
                    if (this.props.language === 'fr') {
                        MMM = ['janv', 'févr', 'mars', 'avril', 'mai', 'juin', 'juil',
            Severity: Minor
            Found in app/components/DateRender.js - About 1 hr to fix

              Function componentWillReceiveProps has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  componentWillReceiveProps(nextProps) {
                      var {router} = this.context, routeData;
                      routeData = getRouteData(router);
              
              
              
              Severity: Minor
              Found in app/views/Homepage/components/Banner.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                Router.run(AppRoutes.routes, (Handler) => {
                    React.render(
                        <FluxComponent flux={flux} connectToStores={[AppStore.ID]}>
                            <Handler/>
                        </FluxComponent>,
                Severity: Major
                Found in app/main.js and 1 other location - About 1 hr to fix
                app/views/Watches/main.js on lines 24..31

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language