herpaderpaldent/seat-groups

<?php
/**
 * MIT License.
 *
 * Copyright (c) 2019. Felix Huber
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */
 
namespace Herpaderpaldent\Seat\SeatGroups\Http\Controllers;
 
use Herpaderpaldent\Seat\SeatGroups\Actions\Managers\AddManagerAction;
use Herpaderpaldent\Seat\SeatGroups\Actions\Managers\RemoveManagerAction;
use Herpaderpaldent\Seat\SeatGroups\Events\GroupApplication;
use Herpaderpaldent\Seat\SeatGroups\Http\Validation\Manager\AddManagerRequest;
use Herpaderpaldent\Seat\SeatGroups\Http\Validation\Manager\RemoveManagerRequest;
use Herpaderpaldent\Seat\SeatGroups\Jobs\GroupSync;
use Herpaderpaldent\Seat\SeatGroups\Models\SeatGroup;
use Illuminate\Http\Request;
use Seat\Web\Acl\AccessManager;
use Seat\Web\Http\Controllers\Controller;
use Yajra\DataTables\DataTables;
 
class SeatGroupUserController extends Controller
{
    use AccessManager;
 
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
 
    }
 
    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function acceptApplication(Request $request, $seat_group_id) //TODO: refactor this to Application Manager
    {
        switch($request->input('action')){
            case 'accept':
                $seatgroup = SeatGroup::find($seat_group_id);
 
                $seatgroup->group()->updateExistingPivot($request->input('group_id'), [
                    'on_waitlist' => 0,
                ]);
 
                return redirect()->back()
                    ->with([
                        'success' => 'User accepted',
                        'activeTab' => 'managed_group',
                        'ModalSeATGroup' => $seat_group_id,
                    ]);
                break;
            case 'deny':
                $seatgroup = SeatGroup::find($seat_group_id);
 
                $seatgroup->group()->detach($request->input('group_id'));
 
                return redirect()
                    ->back()
                    ->with([
                        'success' => 'User removed',
                        'activeTab' => 'managed_group',
                        'ModalSeATGroup' => $seat_group_id,
                    ]);
 
        }
 
    }
 
    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function removeMember($seat_group_id, $group_id)
    {
        $seatgroup = SeatGroup::find($seat_group_id);
 
        $seatgroup->group()->detach($group_id);
 
        return redirect()->back()->with('success', 'User removed');
    }
 
    /**
     * Display the specified resource.
     *
     *
     * @param \Herpaderpaldent\Seat\SeatGroups\Http\Validation\Manager\RemoveManagerRequest $request
     * @param \Herpaderpaldent\Seat\SeatGroups\Actions\Managers\RemoveManagerAction         $action
     *
     * @return \Illuminate\Http\Response
     */
    public function removeManager(RemoveManagerRequest $request, RemoveManagerAction $action)
    {
 
        return $action->execute($request->all());
 
    }
 
    /**
     * Show the form for editing the specified resource.
     *
     * @param \Herpaderpaldent\Seat\SeatGroups\Http\Validation\Manager\AddManagerRequest $request
     * @param \Herpaderpaldent\Seat\SeatGroups\Actions\Managers\AddManagerAction         $action
     *
     * @return \Illuminate\Http\Response
     */
    public function addManager(AddManagerRequest $request, AddManagerAction $action)
    {
        return $action->execute($request->all());
 
    }
 
    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
Function `update` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Method `update` has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    public function update(Request $request, $id)
    {
 
        $seatgroup = SeatGroup::find($id);
 
        //Handle open group
        if ($seatgroup->type == 'open') {
            //First check if the user is allowed to opt-in into a group
            if ($seatgroup->isAllowedToSeeSeatGroup()) {
                //Secound attach user group to SeAT-group
                $seatgroup->group()->attach(auth()->user()->group->id);
                // Add Role to user group
                foreach ($seatgroup->role as $role) {
                    $this->giveGroupRole(auth()->user()->group->id, $role->id);
                }
 
                return redirect()->back()->with([
                    'success' => 'Updated',
                    'activeTab' => 'open_group',
                ]);
            }
 
            return redirect()->back()->with([
                'error' => 'You are not allowed to opt-in into this group',
                'activeTab' => 'open_group',
            ]);
        }
 
        //Handle managed group
        if ($seatgroup->type == 'managed') {
            //First check if the user is allowed to opt-in into a group
            if ($seatgroup->isAllowedToSeeSeatGroup()) {
                //Secound attach user group to SeAT-group
                $seatgroup->group()->attach(auth()->user()->group->id, [
                    'on_waitlist' => 1,
                ]);
 
                event(new GroupApplication(auth()->user()->group, $seatgroup));
 
                return redirect()->back()->with([
                    'info' => 'you successfully applied to ' . $seatgroup->name,
                    'activeTab' => 'managed_group',
                ]);
            }
 
            return redirect()->back()->with([
                'error' => 'You are not allowed to apply for this group',
                'activeTab' => 'managed_group',
            ]);
        }
 
        //Handle hidden group
        if ($seatgroup->type == 'hidden') {
            if (auth()->user()->has('seatgroups.create', false)) {
                $this->validate(request(), [
                    'groups' => 'required|array',
                ]);
                $groups = $request->get('groups');
                foreach ($groups as $group) {
                    $seatgroup->group()->attach($group);
                }
 
Avoid too many `return` statements within this method.
                return redirect()->back()->with('success', 'Updated');
            }
        }
 
Avoid too many `return` statements within this method.
        return redirect()->back()->with('warning', 'ups something went wrong');
    }
 
    public function removeGroupFromSeatGroup($seat_group_id, $group_id)
    {
        SeatGroup::find($seat_group_id)->group()->detach($group_id);
 
        return redirect()->back()->with('success', ' removed');
    }
 
    /**
     * Remove the specified resource from storage.
     *
     * @param  int                                                      $id
     *
     * @return \Illuminate\Http\Response
     */
Function `destroy` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    public function destroy($id)
    {
        $seatgroup = SeatGroup::find($id);
 
        if ($seatgroup->type == 'open') {
            $seatgroup->group()->detach(auth()->user()->group->id);
            // Remove Role from UserGroup
            foreach ($seatgroup->role as $role) {
                $this->removeGroupFromRole(auth()->user()->group->id, $role->id);
            }
        }
        if ($seatgroup->type == 'managed') {
            $seatgroup->group()->detach(auth()->user()->group->id);
            if ($seatgroup->onWaitlist()) {
                return redirect()->back()->with('success', 'Application removed');
            }
        }
 
        dispatch(new GroupSync(auth()->user()->group));
 
        return redirect()->back()->with('success', 'You are no longer member of ' . $seatgroup->name);
    }
 
    public function getMembersTable($id)
    {
        $seatgroup_members = SeatGroup::find($id)->group;
 
Similar blocks of code found in 2 locations. Consider refactoring.
        return DataTables::of($seatgroup_members)
            ->addColumn('name', function ($row) {
                return view('seatgroups::partials.modal-partials.modal-name', compact('row'))->render();
            })
            ->addColumn('actions', function ($row) {
                return view('seatgroups::partials.modal-partials.modal-actions', compact('row'))->render();
            })
            ->rawColumns(['name', 'actions'])
            ->make(true);
    }
}