Sign upLogin

heximcz/mxtoolbox

View on GitHub
Star

Showing 37 of 37 total issues

Function setTestResultArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function setTestResultArray($blacklistHostNamesArray, $alive = true, $ownBlacklist = false)
    {
        if ($this->isArrayInitialized($blacklistHostNamesArray)) {
            $this->testStructure = array();
            foreach ($blacklistHostNamesArray as $index => $blackList) {
Severity: Minor
Found in src/MxToolbox/DataGrid/MxToolboxDataGrid.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkAllDnsbl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkAllDnsbl($addr, &$testResult)
    {
        $this->ipValidator($addr);
        $this->ipAddress = $this->getIpAddressFromDomainName($addr);
        if (count($testResult) > 0) {
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function searchDigResult has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function searchDigResult($domainName) {
        foreach ($this->digOutput as $item) {
            if (($firstLine = strtok($item[0], "\n")) !== false) {
                if ($this->digParser->isDomainNameInString($domainName, $firstLine))
                    return $item[0];
Severity: Minor
Found in src/MxToolbox/NetworkTools/QuickDig.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused local variables such as '$errNo'.
Open

        if ($this->validateIPAddress($addr) && $fss = @fsockopen('tcp://' . $addr, 53, $errNo, $errStr, 5)) {
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The 'getMxRecords()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    private function getMxRecords($hostName)
    {
        if (preg_match("/^[a-zA-Z0-9.\-]{2,256}\.[a-z]{2,6}$/", trim($hostName))) {
            $ptr = dns_get_record($hostName, DNS_MX);
            if (isset($ptr[0]['target'])) {
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid unused local variables such as '$errno'.
Open

        $this->smtpConnection = @stream_socket_client($addr . ':' . $this->smtpPort, $errno, $errstr,
Severity: Minor
Found in src/MxToolbox/NetworkTools/SmtpServerChecks.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid assigning values to variables in if clauses and the like (line '114', column '18').
Open

    private function searchDigResult($domainName) {
        foreach ($this->digOutput as $item) {
            if (($firstLine = strtok($item[0], "\n")) !== false) {
                if ($this->digParser->isDomainNameInString($domainName, $firstLine))
                    return $item[0];
Severity: Minor
Found in src/MxToolbox/NetworkTools/QuickDig.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '59', column '15').
Open

    public function loadBlacklistsFromFile($fileName)
    {
        // user not defined any path
        if (empty($this->blacklistPath))
            $this->setBlacklistFilePath();
Severity: Minor
Found in src/MxToolbox/FileSystem/BlacklistsHostnameFile.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '86', column '15').
Open

    public function makeAliveBlacklistFile(&$aliveBlacklists)
    {
        if (!array_key_exists('blHostName', $aliveBlacklists[0]))
            throw new MxToolboxRuntimeException("Cannot found index ['blHostName'] in array. Build test array first.");
Severity: Minor
Found in src/MxToolbox/FileSystem/BlacklistsHostnameFile.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '61', column '48').
Open

    public function setDnsResolverIP($addr)
    {
        if ($this->validateIPAddress($addr) && $fss = @fsockopen('tcp://' . $addr, 53, $errNo, $errStr, 5)) {
            fclose($fss);
            $this->dnsResolvers[] = $addr;
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused local variables such as '$idx'.
Open

        foreach ($aRecords as $idx => $value) {
Severity: Minor
Found in src/MxToolbox/NetworkTools/SmtpDiagnosticParser.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid assigning values to variables in if clauses and the like (line '93', column '21').
Open

    public function parseDataFromMultiprocessing()
    {
        if(is_array($this->digOutput) && count($this->digOutput) > 0) {

            foreach ($this->testResult as &$blackList) {
Severity: Minor
Found in src/MxToolbox/NetworkTools/QuickDig.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused local variables such as '$errstr'.
Open

        $this->smtpConnection = @stream_socket_client($addr . ':' . $this->smtpPort, $errno, $errstr,
Severity: Minor
Found in src/MxToolbox/NetworkTools/SmtpServerChecks.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$blackList'.
Open

            foreach ($this->testStructure as $index => $blackList) {
Severity: Minor
Found in src/MxToolbox/DataGrid/MxToolboxDataGrid.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$errStr'.
Open

        if ($this->validateIPAddress($addr) && $fss = @fsockopen('tcp://' . $addr, 53, $errNo, $errStr, 5)) {
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid assigning values to variables in if clauses and the like (line '168', column '32').
Open

    public function getIpAddressFromDomainName($addr) {
        
        if ($this->isDomainName($addr) &&
            $this->ipValidator($ipAddress = gethostbyname($addr)))
                return $ipAddress;
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

TODO found
Open

     * TODO: ipv6 support
Severity: Minor
Found in src/MxToolbox/NetworkTools/NetworkTools.php by fixme
Severity
Category
Status
Source
Language