heximcz/mxtoolbox

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function __construct(NetworkTools $netTool, $addr, $myHostName, $mailFrom, $mailRcptTo)

Remove error control operator '@' on line 130.

Open

    private function setSmtpConnect($addr)
    {
        $this->smtpConnection = @stream_socket_client($addr . ':' . $this->smtpPort, $errno, $errstr,
            $this->connTimeout, STREAM_CLIENT_CONNECT);
        if (is_resource($this->smtpConnection)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Avoid unused local variables such as '$errno'.

Open

        $this->smtpConnection = @stream_socket_client($addr . ':' . $this->smtpPort, $errno, $errstr,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Avoid unused local variables such as '$errstr'.

Open

        $this->smtpConnection = @stream_socket_client($addr . ':' . $this->smtpPort, $errno, $errstr,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}