Sign upLogin

hgmnz/keikokuc

View on GitHub
Star

Showing 10 of 10 total issues

File okjson.rb has 410 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'stringio'

# Some parts adapted from
# http://golang.org/src/pkg/json/decode.go and
# http://golang.org/src/pkg/utf8/utf8.go
Severity: Minor
Found in lib/keikokuc/okjson.rb - About 5 hrs to fix

    Method ucharcopy has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
    Open

      def ucharcopy(t, s, i)
    n = s.length - i
    raise Utf8Error if n < 1

    c0 = s[i].ord
    Severity: Minor
    Found in lib/keikokuc/okjson.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unquote has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

      def unquote(q)
    q = q[1...-1]
    a = q.dup # allocate a big enough string
    rubydoesenc = false
    # In ruby >= 1.9, a[w] is a codepoint, not a byte.
    Severity: Minor
    Found in lib/keikokuc/okjson.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unquote has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def unquote(q)
    q = q[1...-1]
    a = q.dup # allocate a big enough string
    rubydoesenc = false
    # In ruby >= 1.9, a[w] is a codepoint, not a byte.
    Severity: Major
    Found in lib/keikokuc/okjson.rb - About 2 hrs to fix

      Method ucharcopy has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def ucharcopy(t, s, i)
    n = s.length - i
    raise Utf8Error if n < 1

    c0 = s[i].ord
      Severity: Minor
      Found in lib/keikokuc/okjson.rb - About 1 hr to fix

        Method strenc has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def strenc(s)
    t = StringIO.new
    t.putc(?")
    r = 0
        Severity: Minor
        Found in lib/keikokuc/okjson.rb - About 1 hr to fix

          Method strenc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def strenc(s)
    t = StringIO.new
    t.putc(?")
    r = 0
          Severity: Minor
          Found in lib/keikokuc/okjson.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method numtok has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def numtok(s)
    m = /-?([1-9][0-9]+|[0-9])([.][0-9]+)?([eE][+-]?[0-9]+)?/.match(s)
    if m && m.begin(0) == 0
      if m[3] && !m[2]
        [:val, m[0], Integer(m[1])*(10**Integer(m[3][1..-1]))]
          Severity: Minor
          Found in lib/keikokuc/okjson.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      if q.length >= r+6
              uchar1 = hexdec4(q[r+2,4])
              uchar = subst(uchar, uchar1)
              if uchar != Ucharerr
                # A valid pair; consume.
          Severity: Major
          Found in lib/keikokuc/okjson.rb - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                return 1
            Severity: Major
            Found in lib/keikokuc/okjson.rb - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language