Sign upLogin

hisamu/php-xbase

View on GitHub
Star
src/Record/VisualFoxproRecord.php

Summary

Maintainability
A
3 hrs
Test Coverage
A
94%

Avoid too many return statements within this method.
Open

                return $this->setCurrency($column, $value);
Severity: Major
Found in src/Record/VisualFoxproRecord.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $this->setVarchar($column, $value);
    Severity: Major
    Found in src/Record/VisualFoxproRecord.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return parent::set($columnName, $value);
      Severity: Major
      Found in src/Record/VisualFoxproRecord.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->setGeneral($column, $value);
        Severity: Major
        Found in src/Record/VisualFoxproRecord.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $this->setFloat($column, $value);
          Severity: Major
          Found in src/Record/VisualFoxproRecord.php - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                protected function setCurrency(Column $column, $value): self
    {
        $this->checkType($column, FieldType::CURRENCY);

        if (is_string($value)) {
            Severity: Minor
            Found in src/Record/VisualFoxproRecord.php and 1 other location - About 35 mins to fix
            src/Record/VisualFoxproRecord.php on lines 96..107

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                protected function setDouble(Column $column, $value): self
    {
        $this->checkType($column, FieldType::DOUBLE);

        if (is_string($value)) {
            Severity: Minor
            Found in src/Record/VisualFoxproRecord.php and 1 other location - About 35 mins to fix
            src/Record/VisualFoxproRecord.php on lines 109..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status