hisptz/90-90-90-cascade-graph-widget

View on GitHub
src/app/core/helpers/draw-chart.helper.ts

Summary

Maintainability
F
5 days
Test Coverage

File draw-chart.helper.ts has 556 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { ChartConfiguration } from '../models/chart-configuration.model';
import * as _ from 'lodash';

export function extendOtherChartOptions(
    initialChartObject: any,
Severity: Major
Found in src/app/core/helpers/draw-chart.helper.ts - About 1 day to fix

    Function getYAxisOptions has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getYAxisOptions(chartConfiguration: any) {
        const yAxes: any[] = chartConfiguration.axes;
        let newYAxes: any[] = [];
    
        if (yAxes.length === 0) {
    Severity: Major
    Found in src/app/core/helpers/draw-chart.helper.ts - About 3 hrs to fix

      Function getRefinedXAxisCategories has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getRefinedXAxisCategories(series: any[]) {
          let newCategories: any[] = [];
          if (series) {
              const seriesDataObjects = _.map(
                  series,
      Severity: Major
      Found in src/app/core/helpers/draw-chart.helper.ts - About 3 hrs to fix

        Function getSeriesValue has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        function getSeriesValue(
            analyticsRows,
            yAxisItemIndex,
            yAxisItemId,
            xAxisItemIndex,
        Severity: Minor
        Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSortableSeries has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getSortableSeries(series, sortOrder) {
            let newSeries = [...series];
            let seriesCategories = [];
        
            /**
        Severity: Minor
        Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

          Function getSeriesData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getSeriesData(
              analyticsObject: any,
              chartConfiguration: any,
              yAxisItemId: string,
              xAxisItems: any[]
          Severity: Minor
          Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

            Function getXAxisOptions has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function getXAxisOptions(
                xAxisCategories: any[],
                chartConfiguration: ChartConfiguration
            ) {
                let xAxisOptions = {};
            Severity: Minor
            Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

              Function getSeriesValue has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function getSeriesValue(
                  analyticsRows,
                  yAxisItemIndex,
                  yAxisItemId,
                  xAxisItemIndex,
              Severity: Minor
              Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

                Function seriesCategoryNamesArray has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            const seriesCategoryNamesArray = _.map(seriesDataObjects, seriesData => {
                                return _.map(seriesData, data => {
                                    // const nameArray = data.name.split('_');
                                    const nameArray = [data.name];
                                    const newCategoryArray = [];
                Severity: Minor
                Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

                  Function updateSeriesWithAxisOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function updateSeriesWithAxisOptions(
                      series: any[],
                      multiAxisOptions: any[],
                      touched: boolean = false
                  ) {
                  Severity: Minor
                  Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

                    Function extendOtherChartOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function extendOtherChartOptions(
                        initialChartObject: any,
                        analyticsObject: any,
                        chartConfiguration: any
                    ): any {
                    Severity: Minor
                    Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

                      Function getRefinedXAxisCategories has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function getRefinedXAxisCategories(series: any[]) {
                          let newCategories: any[] = [];
                          if (series) {
                              const seriesDataObjects = _.map(
                                  series,
                      Severity: Minor
                      Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getAxisItemsNew has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function getAxisItemsNew(
                          analyticsObject: any,
                          axisTypeArray: any[],
                          isCategory: boolean = false
                      ) {
                      Severity: Minor
                      Found in src/app/core/helpers/draw-chart.helper.ts - About 1 hr to fix

                        Function getSeriesValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            analyticsRows,
                            yAxisItemIndex,
                            yAxisItemId,
                            xAxisItemIndex,
                            xAxisItemId,
                        Severity: Minor
                        Found in src/app/core/helpers/draw-chart.helper.ts - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                          if (parentCategory) {
                                                              const parentCategoryIndex = _.findIndex(
                                                                  newCategoryArray,
                                                                  parentCategory
                                                              );
                          Severity: Major
                          Found in src/app/core/helpers/draw-chart.helper.ts - About 45 mins to fix

                            Function getXAxisOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function getXAxisOptions(
                                xAxisCategories: any[],
                                chartConfiguration: ChartConfiguration
                            ) {
                                let xAxisOptions = {};
                            Severity: Minor
                            Found in src/app/core/helpers/draw-chart.helper.ts - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                            function getAllowedChartType(chartType: string): string {
                                let newChartType = '';
                                switch (chartType) {
                                    case 'radar':
                                        newChartType = 'line';
                            Severity: Major
                            Found in src/app/core/helpers/draw-chart.helper.ts and 1 other location - About 3 hrs to fix
                            src/app/core/helpers/draw-visualization.helper.ts on lines 256..272

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 108.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    newSeries = _.map(newSeries, seriesObject => {
                                        const newSeriesObject: any = { ...seriesObject };
                            
                                        if (seriesCategories.length > 0) {
                                            newSeriesObject.data = [
                            Severity: Major
                            Found in src/app/core/helpers/draw-chart.helper.ts and 1 other location - About 3 hrs to fix
                            src/app/core/helpers/draw-chart.helper.ts on lines 312..323

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 99.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    newSeries = _.map(series, seriesObject => {
                                        const newSeriesObject: any = { ...seriesObject };
                            
                                        if (seriesCategories.length > 0) {
                                            newSeriesObject.data = [
                            Severity: Major
                            Found in src/app/core/helpers/draw-chart.helper.ts and 1 other location - About 3 hrs to fix
                            src/app/core/helpers/draw-chart.helper.ts on lines 294..306

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 99.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                {
                                                    color: '#000000',
                                                    dashStyle: 'Solid',
                                                    value: chartConfiguration.targetLineValue,
                                                    width: 2,
                            Severity: Minor
                            Found in src/app/core/helpers/draw-chart.helper.ts and 1 other location - About 35 mins to fix
                            src/app/core/helpers/draw-chart.helper.ts on lines 432..441

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                {
                                                    color: '#000000',
                                                    dashStyle: 'Solid',
                                                    value: chartConfiguration.baseLineValue,
                                                    zIndex: 1000,
                            Severity: Minor
                            Found in src/app/core/helpers/draw-chart.helper.ts and 1 other location - About 35 mins to fix
                            src/app/core/helpers/draw-chart.helper.ts on lines 422..431

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status