Sign upLogin

hisptz/function-maintenance

View on GitHub
Star

Showing 789 of 789 total issues

Function drawTable has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.
Open

export function drawTable(
  analyticsObject,
  tableConfiguration: TableConfiguration,
  legendSets: LegendSet[]
) {
Severity: Minor
Found in src/app/shared/modules/ngx-dhis2-visualization/modules/ngx-dhis2-table/helpers/draw-table.helper.ts - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      this.http
        .get(
          'dataElements.json?filter=name:ilike:stockout&filter=valueType:eq:BOOLEAN&rootJunction=OR&paging=false'
        )
        .subscribe(
Severity: Major
Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/services/function.service.ts and 1 other location - About 2 days to fix
src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/services/function.service.ts on lines 391..457

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 512.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      this.http
        .get(
          'dataElements.json?filter=name:ilike:stockout&filter=valueType:eq:BOOLEAN&rootJunction=OR&paging=false'
        )
        .subscribe(
Severity: Major
Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/services/function.service.ts and 1 other location - About 2 days to fix
src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/services/function.service.ts on lines 311..377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 512.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File draw-chart.helper.ts has 1153 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as _ from 'lodash';
import { ChartConfiguration } from '../models';

export function drawChart(
  incomingAnalyticsObject: any,
Severity: Major
Found in src/app/shared/modules/ngx-dhis2-visualization/modules/ngx-dhis-chart/helpers/draw-chart.helper.ts - About 2 days to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          if (!isNaN(numberLikePeriod)) {
        if (numberLikePeriod.toString().length === 4) {
          periodType = 'Yearly';
        }
      } else {
    Severity: Major
    Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/period.service.ts and 1 other location - About 2 days to fix
    src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/helpers /get-selected-period-type.helper.ts on lines 9..54

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 452.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!isNaN(numberLikePeriod)) {
      if (numberLikePeriod.toString().length === 4) {
        periodType = 'Yearly';
      }
    } else {
    Severity: Major
    Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/helpers /get-selected-period-type.helper.ts and 1 other location - About 2 days to fix
    src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/period.service.ts on lines 53..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 452.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function reducer(
  state = initialState,
  action: IndicatorGroupActions
): State {
  switch (action.type) {
    Severity: Major
    Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/reducers/indicator-group.reducer.ts and 1 other location - About 2 days to fix
    src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/reducers/indicator.reducer.ts on lines 31..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 400.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export function reducer(state = initialState, action: IndicatorActions): State {
  switch (action.type) {
    case IndicatorActionTypes.LoadIndicatorsInitiated: {
      return { ...state, loadInitiated: true };
    }
    Severity: Major
    Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/reducers/indicator.reducer.ts and 1 other location - About 2 days to fix
    src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/reducers/indicator-group.reducer.ts on lines 31..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 400.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File map-files.service.ts has 834 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {Injectable} from '@angular/core';
import * as _ from 'lodash';
import {saveAs} from 'file-saver';
import * as shapeWrite from 'shp-write';
import {Observable} from 'rxjs';
    Severity: Major
    Found in src/app/shared/modules/ngx-dhis2-visualization/modules/map/services/map-files.service.ts - About 2 days to fix

      File function.service.ts has 720 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { Injectable } from '@angular/core';
import * as _ from 'lodash';
import { NgxDhis2HttpClientService } from '@hisptz/ngx-dhis2-http-client';
import { mergeMap, catchError, switchMap, map } from 'rxjs/operators';
import { forkJoin, of, Observable, throwError } from 'rxjs';
      Severity: Major
      Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/services/function.service.ts - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export class IndicatorGroupEffects {
  @Effect({ dispatch: false })
  loadIndicatorGroups$: Observable<any> = this.actions$.pipe(
    ofType(
      fromIndicatorGroupActions.IndicatorGroupActionTypes.LoadIndicatorGroups
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/effects/indicator-group.effects.ts and 1 other location - About 1 day to fix
        src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/effects/indicator.effects.ts on lines 15..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 296.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export class IndicatorEffects {
  @Effect({ dispatch: false })
  loadIndicators$: Observable<any> = this.actions$.pipe(
    ofType(fromIndicatorActions.IndicatorActionTypes.LoadIndicators),
    withLatestFrom(
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/effects/indicator.effects.ts and 1 other location - About 1 day to fix
        src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/data-filter/store/effects/indicator-group.effects.ts on lines 15..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 296.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        export function getMonthlyPeriods(year) {
  const periods = [
    { id: year + '12', name: 'December ' + year },
    { id: year + '11', name: 'November ' + year },
    {
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/helpers /get-monthly-periods.helper.ts and 1 other location - About 1 day to fix
        src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/period.service.ts on lines 104..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 287.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          private _getMonthlyPeriods(year) {
    const periods = [
      { id: year + '12', name: 'December ' + year },
      { id: year + '11', name: 'November ' + year },
      {
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/period.service.ts and 1 other location - About 1 day to fix
        src/app/shared/modules/ngx-dhis2-data-selection-filter/modules/period-filter/helpers /get-monthly-periods.helper.ts on lines 1..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 287.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          downloadMapVisualizationAsGML(mapVisualization) {
    const payload = mapVisualization.payload && mapVisualization.payload !== '' ? mapVisualization.payload : {};
    const legends = payload.mapLegends;
    const visualization = payload.visualization;
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-visualization/modules/map/services/map-files.service.ts and 1 other location - About 1 day to fix
        src/app/shared/modules/ngx-dhis2-visualization/modules/map/services/map-files.service.ts on lines 45..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 255.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          downloadMapVisualizationAsKML(mapVisualization) {
    const payload = mapVisualization.payload && mapVisualization.payload !== '' ? mapVisualization.payload : {};
    const legends = payload.mapLegends;
    const visualization = payload.visualization;
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-visualization/modules/map/services/map-files.service.ts and 1 other location - About 1 day to fix
        src/app/shared/modules/ngx-dhis2-visualization/modules/map/services/map-files.service.ts on lines 72..98

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 255.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function drawTable has 263 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function drawTable(
  analyticsObject,
  tableConfiguration: TableConfiguration,
  legendSets: LegendSet[]
) {
        Severity: Major
        Found in src/app/shared/modules/ngx-dhis2-visualization/modules/ngx-dhis2-table/helpers/draw-table.helper.ts - About 1 day to fix

          File colorBrewer.ts has 579 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          // This product includes color specifications and designs developed by Cynthia Brewer (http://colorbrewer.org/).
// Please see license at http://colorbrewer.org/export/LICENSE.txt
export const colorBrewer = {
  YlGn: {
    3: ['#f7fcb9', '#addd8e', '#31a354'],
          Severity: Major
          Found in src/app/shared/modules/ngx-dhis2-visualization/modules/map/utils/colorBrewer.ts - About 1 day to fix

            Function sortData has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
            Open

              sortData(tableObject, n, isLastItem) {
    if (tableObject.columns.length === 1 && isLastItem) {
      this.current_sorting = [];
      this.current_sorting[n] = true;
      let table,
            Severity: Minor
            Found in src/app/shared/modules/ngx-dhis2-visualization/modules/ngx-dhis2-table/components/table-item/table-item.component.ts - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              _getLabelLatlng(geometry) {
    const coords = geometry.coordinates;
    let biggestRing;

    if (geometry.type === 'Point') {
            Severity: Major
            Found in src/app/shared/modules/ngx-dhis2-visualization/modules/map/lib/geoJsonExtended.ts and 1 other location - About 1 day to fix
            src/app/shared/modules/ngx-dhis2-visualization/modules/map/utils/layers.ts on lines 60..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 209.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language