Sign upLogin

historyforge/historyforge

View on GitHub
Star
app/services/people/nicknames.rb

Summary

Maintainability
B
5 hrs
Test Coverage

File nicknames.rb has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module People
  class Nicknames
    def self.matches_for(name, gender = nil)
      match_against = if gender
                        gender.downcase == 'm' ? MALE_NAMES : FEMALE_NAMES
Severity: Minor
Found in app/services/people/nicknames.rb - About 5 hrs to fix

    Method matches_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.matches_for(name, gender = nil)
      match_against = if gender
                        gender.downcase == 'm' ? MALE_NAMES : FEMALE_NAMES
                      else
                        ALL_NAMES
    Severity: Minor
    Found in app/services/people/nicknames.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status