Sign upLogin

hnhdigital-os/laravel-dynamic-filter

View on GitHub
Star

Showing 70 of 70 total issues

Method getCurrentSearchQuery has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCurrentSearchQuery($options, $class_name, $model_filter = false)
    {
        $class_name = 'App\\Models\\'.$class_name;
        extract($options);
        $route_name = (!isset($route_name)) ? $current_model : $route_name;
Severity: Major
Found in src/Traits/ControllerTrait.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        $('.common-module-content-search').on('click', '.action-change-filter', function(e) {
      var search_table_id = $(this).parents('.common-module-content-search').attr('id');
      $('#'+search_table_id+'-tab2').tab('show');
    });
    Severity: Major
    Found in js/search.js and 1 other location - About 2 hrs to fix
    js/search.js on lines 120..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        $('.common-module-content-search').on('click', '.action-apply-filter', function(e) {
      var search_table_id = $(this).parents('.common-module-content-search').attr('id');
      $('#'+search_table_id+'-form button[type=submit]').trigger('click');
    });
    Severity: Major
    Found in js/search.js and 1 other location - About 2 hrs to fix
    js/search.js on lines 126..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function scopeModelJoin has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public function scopeModelJoin($query, $relationships, $operator = '=', $type = 'left', $where = false)
    {
        if (!is_array($relationships)) {
            $relationships = [$relationships];
        }
    Severity: Minor
    Found in src/Traits/ModelTrait.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method scopeModelJoin has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function scopeModelJoin($query, $relationships, $operator = '=', $type = 'left', $where = false)
    {
        if (!is_array($relationships)) {
            $relationships = [$relationships];
        }
    Severity: Minor
    Found in src/Traits/ModelTrait.php - About 1 hr to fix

      Function returnSearchResult has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)
    {
        unset($search_request['rows']);

        // Save filters to session
      Severity: Minor
      Found in src/Traits/ControllerTrait.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getCurrentSearchDetails has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getCurrentSearchDetails($use_session, $settings, $options, $search_name)
    {
        extract($options);

        $options['route_paramater'] = (empty($options['route_paramater'])) ? $current_model : $options['route_paramater'];
      Severity: Minor
      Found in src/Traits/ControllerTrait.php - About 1 hr to fix

        Method runStandardSubSearch has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function runStandardSubSearch(&$view_data, $config, $model)
    {
        foreach ($config as $config_entry) {
            list($page, $name, $variable, $method, $class, $view_settings, $search_settings) = array_pad($config_entry, 7, null);
        Severity: Minor
        Found in src/Traits/ControllerTrait.php - About 1 hr to fix

          Method checkSearchResults has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected static function checkSearchResults($table, $result, &$search_request, $name, $column_span = 1, $config = [])
    {
        self::pagination($result, $search_request);

        $thead = false;
          Severity: Minor
          Found in src/Traits/ControllerTrait.php - About 1 hr to fix

            Method showSearchAppliedFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected static function showSearchAppliedFilters(&$tbody, &$search_request, $result, $model, $column_span = 1, $options = [])
    {
        self::pagination($result, $search_request);

        // Applied filters
            Severity: Minor
            Found in src/Traits/ControllerTrait.php - About 1 hr to fix

              Method scopeApplyAttributeFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function scopeApplyAttributeFilters($query, $search_request)
    {
        if (isset($search_request['filters']) && is_array($search_request['filters']) && !empty($search_request['filters'])) {

            // Get available filters
              Severity: Minor
              Found in src/Traits/ModelTrait.php - About 1 hr to fix

                Method getAppliedFiltersArray has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getAppliedFiltersArray($search_request)
    {
        $model = (new static());
        $result = [];
        foreach ($model->getFilterAttributes() as $filter_name => $filter_settings) {
                Severity: Minor
                Found in src/Traits/ModelTrait.php - About 1 hr to fix

                  Method returnSearchResult has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)
    {
        unset($search_request['rows']);

        // Save filters to session
                  Severity: Minor
                  Found in src/Traits/ControllerTrait.php - About 1 hr to fix

                    Function getCurrentSearchDetails has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getCurrentSearchDetails($use_session, $settings, $options, $search_name)
    {
        extract($options);

        $options['route_paramater'] = (empty($options['route_paramater'])) ? $current_model : $options['route_paramater'];
                    Severity: Minor
                    Found in src/Traits/ControllerTrait.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (isset($search_request['filters']) && count($search_request['filters'])) {
                $template = 'No <strong>%s</strong> can be found with the <strong>applied filters</strong>';
                if (isset($config['attached_with_filter_no_results']) && $config['search_tab'] == $config['attached_tab']) {
                    $template = $config['attached_with_filter_no_results'];
                } elseif (isset($config['unattached_with_filter_no_results']) && $config['search_tab'] != $config['attached_tab']) {
                    Severity: Major
                    Found in src/Traits/ControllerTrait.php and 1 other location - About 1 hr to fix
                    src/Traits/ControllerTrait.php on lines 402..411

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 104.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                } else {
                $template = 'No <strong>%s</strong> exist';
                if (isset($config['attached_no_filter_no_results']) && $config['search_tab'] == $config['attached_tab']) {
                    $template = $config['attached_no_filter_no_results'];
                } elseif (isset($config['unattached_no_filter_no_results']) && $config['search_tab'] != $config['attached_tab']) {
                    Severity: Major
                    Found in src/Traits/ControllerTrait.php and 1 other location - About 1 hr to fix
                    src/Traits/ControllerTrait.php on lines 393..411

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 104.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function getFilters has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        getFilters: function(search_table_id)
    {
        var current_filters = {
          'filters': {}
        };
                    Severity: Minor
                    Found in js/search.js - About 1 hr to fix

                      Method validateOperators has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          private static function validateOperators($filter, &$method, &$arguments, $model, $filter_setting, $operator, $value1, $value2)
                      Severity: Major
                      Found in src/Traits/ModelTrait.php - About 1 hr to fix

                        Function runStandardSubSearch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function runStandardSubSearch(&$view_data, $config, $model)
    {
        foreach ($config as $config_entry) {
            list($page, $name, $variable, $method, $class, $view_settings, $search_settings) = array_pad($config_entry, 7, null);
                        Severity: Minor
                        Found in src/Traits/ControllerTrait.php - About 55 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if (response.left_arrow) {
                $('#'+search_table_id+' .search-result-up').addClass('btn-primary btn-outline');
                $('#'+search_table_id+' .search-result-first').addClass('btn-primary btn-outline');
                has_search = true;
            } else {
                        Severity: Minor
                        Found in js/search.js and 1 other location - About 45 mins to fix
                        js/search.js on lines 367..375

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 50.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language