Sign upLogin

hnhdigital-os/laravel-dynamic-filter

View on GitHub
Star
src/Traits/ControllerTrait.php

Summary

Maintainability
F
5 days
Test Coverage

File ControllerTrait.php has 432 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Bluora\LaravelDynamicFilter\Traits;

use Bluora\LaravelDynamicFilter\Objects\SearchViewOptions;
Severity: Minor
Found in src/Traits/ControllerTrait.php - About 6 hrs to fix

    Function getCurrentSearchQuery has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getCurrentSearchQuery($options, $class_name, $model_filter = false)
    {
        $class_name = 'App\\Models\\'.$class_name;
        extract($options);
        $route_name = (!isset($route_name)) ? $current_model : $route_name;
    Severity: Minor
    Found in src/Traits/ControllerTrait.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function showSearchAppliedFilters has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static function showSearchAppliedFilters(&$tbody, &$search_request, $result, $model, $column_span = 1, $options = [])
    {
        self::pagination($result, $search_request);

        // Applied filters
    Severity: Minor
    Found in src/Traits/ControllerTrait.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loadFilter has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadFilter(HttpRequest $request, ModelFilter $model_filter)
    {
        $model_name = 'App\\Models\\'.$request->get('model');
        $method_name = $request->get('method');
    Severity: Minor
    Found in src/Traits/ControllerTrait.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method loadFilter has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadFilter(HttpRequest $request, ModelFilter $model_filter)
    {
        $model_name = 'App\\Models\\'.$request->get('model');
        $method_name = $request->get('method');
    Severity: Major
    Found in src/Traits/ControllerTrait.php - About 2 hrs to fix

      Function checkSearchResults has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function checkSearchResults($table, $result, &$search_request, $name, $column_span = 1, $config = [])
    {
        self::pagination($result, $search_request);

        $thead = false;
      Severity: Minor
      Found in src/Traits/ControllerTrait.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getCurrentSearchQuery has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getCurrentSearchQuery($options, $class_name, $model_filter = false)
    {
        $class_name = 'App\\Models\\'.$class_name;
        extract($options);
        $route_name = (!isset($route_name)) ? $current_model : $route_name;
      Severity: Major
      Found in src/Traits/ControllerTrait.php - About 2 hrs to fix

        Function returnSearchResult has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)
    {
        unset($search_request['rows']);

        // Save filters to session
        Severity: Minor
        Found in src/Traits/ControllerTrait.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method runStandardSubSearch has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function runStandardSubSearch(&$view_data, $config, $model)
    {
        foreach ($config as $config_entry) {
            list($page, $name, $variable, $method, $class, $view_settings, $search_settings) = array_pad($config_entry, 7, null);
        Severity: Minor
        Found in src/Traits/ControllerTrait.php - About 1 hr to fix

          Method getCurrentSearchDetails has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getCurrentSearchDetails($use_session, $settings, $options, $search_name)
    {
        extract($options);

        $options['route_paramater'] = (empty($options['route_paramater'])) ? $current_model : $options['route_paramater'];
          Severity: Minor
          Found in src/Traits/ControllerTrait.php - About 1 hr to fix

            Method showSearchAppliedFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected static function showSearchAppliedFilters(&$tbody, &$search_request, $result, $model, $column_span = 1, $options = [])
    {
        self::pagination($result, $search_request);

        // Applied filters
            Severity: Minor
            Found in src/Traits/ControllerTrait.php - About 1 hr to fix

              Method checkSearchResults has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected static function checkSearchResults($table, $result, &$search_request, $name, $column_span = 1, $config = [])
    {
        self::pagination($result, $search_request);

        $thead = false;
              Severity: Minor
              Found in src/Traits/ControllerTrait.php - About 1 hr to fix

                Method returnSearchResult has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)
    {
        unset($search_request['rows']);

        // Save filters to session
                Severity: Minor
                Found in src/Traits/ControllerTrait.php - About 1 hr to fix

                  Function getCurrentSearchDetails has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getCurrentSearchDetails($use_session, $settings, $options, $search_name)
    {
        extract($options);

        $options['route_paramater'] = (empty($options['route_paramater'])) ? $current_model : $options['route_paramater'];
                  Severity: Minor
                  Found in src/Traits/ControllerTrait.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function runStandardSubSearch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function runStandardSubSearch(&$view_data, $config, $model)
    {
        foreach ($config as $config_entry) {
            list($page, $name, $variable, $method, $class, $view_settings, $search_settings) = array_pad($config_entry, 7, null);
                  Severity: Minor
                  Found in src/Traits/ControllerTrait.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method checkSearchResults has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected static function checkSearchResults($table, $result, &$search_request, $name, $column_span = 1, $config = [])
                  Severity: Minor
                  Found in src/Traits/ControllerTrait.php - About 45 mins to fix

                    Method showSearchAppliedFilters has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        protected static function showSearchAppliedFilters(&$tbody, &$search_request, $result, $model, $column_span = 1, $options = [])
                    Severity: Minor
                    Found in src/Traits/ControllerTrait.php - About 45 mins to fix

                      Method returnSearchResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)
                      Severity: Minor
                      Found in src/Traits/ControllerTrait.php - About 35 mins to fix

                        Function getSearchAppliedFilters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected static function getSearchAppliedFilters($controller_name, $distinct_session = '', $use_session = false)
    {

        // Filter provided.
        if (is_array($use_session)) {
                        Severity: Minor
                        Found in src/Traits/ControllerTrait.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this method.
                        Open

                                return $query;
                        Severity: Major
                        Found in src/Traits/ControllerTrait.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return ['filters' => [], 'rows' => ''];
                          Severity: Major
                          Found in src/Traits/ControllerTrait.php - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        } else {
                $template = 'No <strong>%s</strong> exist';
                if (isset($config['attached_no_filter_no_results']) && $config['search_tab'] == $config['attached_tab']) {
                    $template = $config['attached_no_filter_no_results'];
                } elseif (isset($config['unattached_no_filter_no_results']) && $config['search_tab'] != $config['attached_tab']) {
                            Severity: Major
                            Found in src/Traits/ControllerTrait.php and 1 other location - About 1 hr to fix
                            src/Traits/ControllerTrait.php on lines 393..411

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 104.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        if (isset($search_request['filters']) && count($search_request['filters'])) {
                $template = 'No <strong>%s</strong> can be found with the <strong>applied filters</strong>';
                if (isset($config['attached_with_filter_no_results']) && $config['search_tab'] == $config['attached_tab']) {
                    $template = $config['attached_with_filter_no_results'];
                } elseif (isset($config['unattached_with_filter_no_results']) && $config['search_tab'] != $config['attached_tab']) {
                            Severity: Major
                            Found in src/Traits/ControllerTrait.php and 1 other location - About 1 hr to fix
                            src/Traits/ControllerTrait.php on lines 402..411

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 104.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status