Sign upLogin

hnhdigital-os/laravel-frontend-assets

View on GitHub
Star
src/CodeMirror.php

Summary

Maintainability
A
0 mins
Test Coverage

Showing 3 of 3 total issues

The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($version = false)
Severity: Minor
Found in src/CodeMirror.php by phpmd

The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $version = app('FrontendAsset')->version(class_basename(__CLASS__), $version);
            app('FrontendAsset')->add('https://cdnjs.cloudflare.com/ajax/libs/codemirror/'.$version.'/codemirror.min.css');
            app('FrontendAsset')->add('https://cdnjs.cloudflare.com/ajax/libs/codemirror/'.$version.'/codemirror.min.js');
        }
Severity: Minor
Found in src/CodeMirror.php by phpmd

Avoid unused private fields such as '$verison'.
Open

    private $verison;
Severity: Minor
Found in src/CodeMirror.php by phpmd
Category
Status