Sign upLogin

hnhdigital-os/laravel-html-generator

View on GitHub
Star

Showing 68 of 68 total issues

The method checked has a boolean flag argument $check_value, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function checked(?bool $value = true, ?bool $check_value = true): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method attrIf has a boolean flag argument $check, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function attrIf(?bool $check = false, mixed ...$attr): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method checked has a boolean flag argument $value, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function checked(?bool $value = true, ?bool $check_value = true): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method openNew has a boolean flag argument $open_normally, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function openNew(bool $open_normally = false): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addClassIf has a boolean flag argument $check, which is a certain sign of a Single Responsibility Principle violation.
Open

        ?bool $check = false,
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addAttrIf has a boolean flag argument $check, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addAttrIf(?bool $check = false, mixed ...$attr): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method style has a boolean flag argument $replace, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function style(?string $value = null, bool $replace = false): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method readonly has a boolean flag argument $value, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function readonly(bool $value = true): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method disable has a boolean flag argument $value, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function disable(bool $value = true, bool $check_value = true): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method disable has a boolean flag argument $check_value, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function disable(bool $value = true, bool $check_value = true): self
Severity: Minor
Found in src/Html.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Function remove has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function remove(): ?self
    {
        $parent = $this->parent;

        if (!is_null($parent)) {
Severity: Minor
Found in src/Markup.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class Html has 1366 lines of code. Current threshold is 1000. Avoid really long classes.
Open

class Html extends Markup
{
    /**
     * @param string       $tag
     * @param array<mixed> $arguments
Severity: Minor
Found in src/Html.php by phpmd

The method addOptionsArray() has an NPath complexity of 544. The configured NPath complexity threshold is 200.
Open

    public function addOptionsArray(
        array $data,
        bool|string $data_value,
        bool|string|null $data_name,
        array|string|null $selected_value = []
Severity: Minor
Found in src/Html.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method valueDate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $value = '';
        }
Severity: Minor
Found in src/Html.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$value'.
Open

    public function attr($attribute, ?string $value = null): static
Severity: Minor
Found in src/Markup.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method toString uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $string .= $this->text;
            $string .= $this->contentToString();
        }
Severity: Minor
Found in src/Markup.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this[$attribute] = $value;
        }
Severity: Minor
Found in src/Markup.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method attributesToString uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                        } else {
                            continue;
                        }
Severity: Minor
Found in src/Markup.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method addClass uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $this->attributeList['class'] = [];
            }
Severity: Minor
Found in src/Html.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused parameters such as '$attribute'.
Open

    public function attr($attribute, ?string $value = null): static
Severity: Minor
Found in src/Markup.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Severity
Category
Status
Source
Language