hnhdigital-os/laravel-model-filter

View on GitHub

Showing 194 of 194 total issues

Method getCurrentSearchDetails has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getCurrentSearchDetails($use_session, $settings, $options, $search_name)
    {
        if (request()->ajax()) {
            $settings_data = request()->all();
        } else {
Severity: Minor
Found in src/Traits/ControllerTrait.php - About 1 hr to fix

    Method checkSearchResults has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected static function checkSearchResults($table, $result, &$search_request, $name, $column_span = 1, $config = [])
        {
            self::pagination($result, $search_request);
    
            $thead = false;
    Severity: Minor
    Found in src/Traits/ControllerTrait.php - About 1 hr to fix

      Method scopeApplyAttributeFilters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function scopeApplyAttributeFilters($query, $search_request)
          {
              if (isset($search_request['filters']) && is_array($search_request['filters']) && !empty($search_request['filters'])) {
      
                  // Get available filters
      Severity: Minor
      Found in src/Traits/ModelTrait.php - About 1 hr to fix

        Method getAppliedFiltersArray has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAppliedFiltersArray($search_request)
            {
                $model = (new static());
                $result = [];
                foreach ($model->getFilterAttributes() as $filter_name => $filter_settings) {
        Severity: Minor
        Found in src/Traits/ModelTrait.php - About 1 hr to fix

          Method returnSearchResult has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected static function returnSearchResult($controller_name, $distinct_session, $search_request, $response, $extra_response = false)
              {
                  unset($search_request['rows']);
          
                  // Save filters to session
          Severity: Minor
          Found in src/Traits/ControllerTrait.php - About 1 hr to fix

            Method showSearchAppliedFilters has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected static function showSearchAppliedFilters(&$tbody, &$search_request, $result, $model, $column_span = 1)
                {
                    self::pagination($result, $search_request);
            
                    // Applied filters
            Severity: Minor
            Found in src/Traits/ControllerTrait.php - About 1 hr to fix

              Function runStandardSubSearch has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function runStandardSubSearch(&$view_data, $config, $model)
                  {
                      foreach ($config as $config_entry) {
                          list($page, $name, $variable, $method, $class, $view_settings, $search_settings) = array_pad($config_entry, 7, null);
              
              
              Severity: Minor
              Found in src/Traits/ControllerTrait.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          } else {
                              $template = 'No <strong>%s</strong> exist';
                              if (isset($config['attached_no_filter_no_results']) && $config['search_tab'] == $config['attached_tab']) {
                                  $template = $config['attached_no_filter_no_results'];
                              } elseif (isset($config['unattached_no_filter_no_results']) && $config['search_tab'] != $config['attached_tab']) {
              Severity: Major
              Found in src/Traits/ControllerTrait.php and 1 other location - About 1 hr to fix
              src/Traits/ControllerTrait.php on lines 396..414

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 104.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (isset($search_request['filters']) && count($search_request['filters'])) {
                              $template = 'No <strong>%s</strong> can be found with the <strong>applied filters</strong>';
                              if (isset($config['attached_with_filter_no_results']) && $config['search_tab'] == $config['attached_tab']) {
                                  $template = $config['attached_with_filter_no_results'];
                              } elseif (isset($config['unattached_with_filter_no_results']) && $config['search_tab'] != $config['attached_tab']) {
              Severity: Major
              Found in src/Traits/ControllerTrait.php and 1 other location - About 1 hr to fix
              src/Traits/ControllerTrait.php on lines 405..414

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 104.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid using undefined variables such as '$current_model' which will lead to PHP notices.
              Open

                      $options['route_paramater'] = (empty($options['route_paramater'])) ? $current_model : $options['route_paramater'];
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$attached_method_source' which will lead to PHP notices.
              Open

                              if (isset($attached_method_source)) {
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$attached_button_name' which will lead to PHP notices.
              Open

                      $options['attached_button_name'] = (isset($attached_button_name)) ? $attached_button_name : 'Remove '.str_plural($search_name, 1);
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$model' which will lead to PHP notices.
              Open

                                  return $model->$attached_method_source();
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$unattached_tab' which will lead to PHP notices.
              Open

                      $options['unattached_tab'] = (isset($unattached_tab)) ? $unattached_tab : 'available-'.str_plural($search_name, 2);
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$unattached_method_source' which will lead to PHP notices.
              Open

                                  return $model->$unattached_method_source();
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$unattached_button_color' which will lead to PHP notices.
              Open

                      $options['unattached_button_color'] = (isset($unattached_button_color)) ? $unattached_button_color : 'primary';
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$unattached_button_icon' which will lead to PHP notices.
              Open

                      $options['unattached_button_icon'] = (isset($unattached_button_icon)) ? $unattached_button_icon : 'plus';
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$attached_tab' which will lead to PHP notices.
              Open

                      $options['attached_tab'] = (isset($attached_tab)) ? $attached_tab : str_plural($search_name, 2);
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$attached_button_name' which will lead to PHP notices.
              Open

                      $options['attached_button_name'] = (isset($attached_button_name)) ? $attached_button_name : 'Remove '.str_plural($search_name, 1);
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$current_model' which will lead to PHP notices.
              Open

                      $options['search_request'] = $this->getSearchAppliedFilters($current_model.'.'.$search_name.'.search', $options['model_id'].$options['search_tab'], $use_session);
              Severity: Minor
              Found in src/Traits/ControllerTrait.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Severity
              Category
              Status
              Source
              Language