Sign upLogin

hnhdigital-os/laravel-model-json

View on GitHub
Star

Showing 9 of 9 total issues

Function getDirty has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function getDirty($include_json = false)
    {
        $dirty = parent::getDirty();

        if (!empty($this->json_values)) {
Severity: Minor
Found in src/JsonColumnTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long variable names like $internal_original_value. Keep variable name length under 20.
Open

    private $internal_original_value = '';
Severity: Minor
Found in src/JsonColumnValue.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $internal_original_data. Keep variable name length under 20.
Open

    private $internal_original_data = [];
Severity: Minor
Found in src/JsonColumnValue.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Function getOriginal has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function getOriginal($key = null, $default = null)
    {
        $original = parent::getOriginal($key, $default);
        if (!empty($this->json_values)) {
            if ($key === null) {
Severity: Minor
Found in src/JsonColumnTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkValuesUponSave has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkValuesUponSave()
    {
        foreach ($this->getJsonColumns() as $column_name) {
            if (isset($this->attributes[$column_name]) && !is_string($this->attributes[$column_name])) {
                if (is_array($this->attributes[$column_name])) {
Severity: Minor
Found in src/JsonColumnTrait.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDirty has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function getDirty()
    {
        $dirty = [];
        foreach ($this->getCurrent() as $key => $value) {
Severity: Minor
Found in src/JsonColumnValue.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method fromJson has a boolean flag argument $asObject, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function fromJson($value, $asObject = false)
Severity: Minor
Found in src/JsonColumnTrait.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Function inspectJson has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function inspectJson()
    {
        if (!empty($this->json_columns)) {
            foreach ($this->json_columns as $column_name) {
                if (!in_array($column_name, static::$protected_columns)) {
Severity: Minor
Found in src/JsonColumnTrait.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid assigning values to variables in if clauses and the like (line '258', column '21').
Open

    public function getDirty($include_json = false)
    {
        $dirty = parent::getDirty();

        if (!empty($this->json_values)) {
Severity: Minor
Found in src/JsonColumnTrait.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Severity
Category
Status
Source
Language