Sign upLogin

hnhdigital-os/laravel-navigation-builder

View on GitHub
Star

Showing 61 of 61 total issues

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public $id = '';
Severity: Minor
Found in src/Item.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid deeply nested control flow statements.
Open

                            if (($index = array_search($input_value, $current_value_array)) !== false) {
                                unset($current_value_array[$index]);
                            }
Severity: Major
Found in src/Item.php - About 45 mins to fix

    Function checkItemIsActive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function checkItemIsActive($item)
    {
        if ($this->getActive()) {
            return true;
        }
    Severity: Minor
    Found in src/Item.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function renderDropdown has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function renderDropdown()
    {
        $menu_source = Arr::get($this->option, 'dropdown_source', null);
        $config = Arr::get($this->option, 'dropdown_config', null);
    Severity: Minor
    Found in src/Item.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $this;
    Severity: Major
    Found in src/Item.php - About 30 mins to fix

      Missing class import via use statement (line '131', column '23').
      Open

                  throw new \Exception('Menu can not be found.');
      Severity: Minor
      Found in src/Navigation.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid too many return statements within this method.
      Open

                  return $this;
      Severity: Major
      Found in src/Item.php - About 30 mins to fix

        The method children has a boolean flag argument $depth, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function children($depth = false)
        Severity: Minor
        Found in src/Item.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method can has a boolean flag argument $user, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function can($ability, $model, $user = false)
        Severity: Minor
        Found in src/Item.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        Missing class import via use statement (line '137', column '23').
        Open

                    throw new \Exception('Item can not be found.');
        Severity: Minor
        Found in src/Navigation.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Avoid too many return statements within this method.
        Open

                return Html::$item_tag($before_tag_html.$html.$after_tag_html)->addAttributes($this->item_attribute)->s();
        Severity: Major
        Found in src/Item.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return $this;
          Severity: Major
          Found in src/Menu.php - About 30 mins to fix

            The method __construct has a boolean flag argument $collections, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function __construct($name, $collections = false)
            Severity: Minor
            Found in src/Menu.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
    public function bar($flag = true) {
    }
}

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            Avoid too many return statements within this method.
            Open

                        return $this;
            Severity: Major
            Found in src/Item.php - About 30 mins to fix

              The method setActive has a boolean flag argument $active, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public function setActive($active = true, $update_parents = true)
              Severity: Minor
              Found in src/Item.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
    public function bar($flag = true) {
    }
}

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              The method render has a boolean flag argument $parent_id, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public function render($parent_id = false)
              Severity: Minor
              Found in src/Menu.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
    public function bar($flag = true) {
    }
}

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              The method setActive has a boolean flag argument $update_parents, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public function setActive($active = true, $update_parents = true)
              Severity: Minor
              Found in src/Item.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
    public function bar($flag = true) {
    }
}

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              The method checkActive has a boolean flag argument $update_parents, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  private function checkActive($update_parents = true)
              Severity: Minor
              Found in src/Item.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
    public function bar($flag = true) {
    }
}

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              Avoid too many return statements within this method.
              Open

                          return '';
              Severity: Major
              Found in src/Item.php - About 30 mins to fix

                The method filter has a boolean flag argument $include_children, which is a certain sign of a Single Responsibility Principle violation.
                Open

                    public function filter($property_name, $value, $include_children = false)
                Severity: Minor
                Found in src/Menu.php by phpmd

                BooleanArgumentFlag

                Since: 1.4.0

                A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

                Example

                class Foo {
    public function bar($flag = true) {
    }
}

                Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

                Severity
                Category
                Status
                Source
                Language