Sign upLogin

hnhdigital-os/laravel-resources-loader

View on GitHub
Star

Showing 83 of 83 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (!env('APP_CDN', true)) {
            Resource::add('vendor/text-diff-patch.min.js');
            Resource::add('vendor/text-diff.min.js');
        } else {
            $version = Resource::version(class_basename(__CLASS__), $version);
Severity: Major
Found in src/Assets/TextDiff.php and 2 other locations - About 45 mins to fix
src/Assets/Dropzone.php on lines 12..19
src/Assets/Steps.php on lines 14..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (!env('APP_CDN', true)) {
            Resource::add('vendor/dropzone.js');
            Resource::add('vendor/dropzone.css');
        } else {
            $version = Resource::version(class_basename(__CLASS__), $version);
Severity: Major
Found in src/Assets/Dropzone.php and 2 other locations - About 45 mins to fix
src/Assets/Steps.php on lines 14..21
src/Assets/TextDiff.php on lines 11..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (!env('APP_CDN', true)) {
            Resource::add('vendor/steps.min.js');
            Resource::add('vendor/steps.css');
        } else {
            $version = Resource::version(class_basename(__CLASS__), $version);
Severity: Major
Found in src/Assets/Steps.php and 2 other locations - About 45 mins to fix
src/Assets/Dropzone.php on lines 12..19
src/Assets/TextDiff.php on lines 11..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function elixir has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function elixir($file)
    {
        if (substr($file, 0, 4) === 'http') {
            return $file;
        }
Severity: Minor
Found in src/Resource.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($version = false)
Severity: Minor
Found in src/Assets/GoogleMaps.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method version has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function version($name, $version = false)
Severity: Minor
Found in src/Resource.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addAfter has a boolean flag argument $onUnknownExtension, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addAfter($file1, $file2, $params = 'footer', $onUnknownExtension = false)
Severity: Minor
Found in src/Resource.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($version = false)
Severity: Minor
Found in src/Assets/MultiEmailInput.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid too many return statements within this method.
Open

                return '/assets/'.$file;
Severity: Major
Found in src/Resource.php - About 30 mins to fix

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/Ladda.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/IcheckInput.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/Slimscroll.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/StickyTabs.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/TextDiff.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method svg has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public static function svg($country_code, $version = false)
    Severity: Minor
    Found in src/Assets/FlagIcon.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/Flot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/FlotTooltip.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/Bootstrap.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/DateInput.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($version = false)
    Severity: Minor
    Found in src/Assets/TimePickerInput.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Severity
    Category
    Status
    Source
    Language