Sign upLogin

hnhdigital-os/laravel-resources-loader

View on GitHub
Star
src/Assets/Ladda.php

Summary

Maintainability
A
0 mins
Test Coverage

Showing 2 of 2 total issues

The method __construct has a boolean flag argument $version, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function __construct($version = false)
Severity: Minor
Found in src/Assets/Ladda.php by phpmd

The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $version = Resource::version(class_basename(__CLASS__), $version);
            Resource::add('https://cdnjs.cloudflare.com/ajax/libs/Ladda/'.$version.'/spin.min.js');
            Resource::add('https://cdnjs.cloudflare.com/ajax/libs/Ladda/'.$version.'/ladda.min.js');
            Resource::add('https://cdnjs.cloudflare.com/ajax/libs/Ladda/'.$version.'/ladda.jquery.min.js');
Severity: Minor
Found in src/Assets/Ladda.php by phpmd

There are no issues that match your filters.

Category
Status