Sign upLogin

hnhdigital-os/laravel-search-components

View on GitHub
Star

Showing 70 of 70 total issues

Function autoInit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  autoInit: function() {
    $('.hnhdigital-search-form').on('submit', function() {
      var form = $(this);
      var results = $('.'+$(this).attr('id').replace(new RegExp('-form$'), '-results'));
      var page = $(form).find('[name=page]').val();
Severity: Minor
Found in resources/js/search.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setRequest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function setRequest($name)
    {
        // Get the data from the request or provided array.
        $request = is_array($name) ? $name : request($name, []);
Severity: Minor
Found in src/Search.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __call has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function __call($method, $arguments)
    {
        preg_match('/^(get|set)(.*)$/', $method, $matches);

        if (count($matches)) {
Severity: Minor
Found in src/Search.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateResults has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  updateResults: function(results, response) {
    if (!results.hasClass('hnhdigital-search-results')) {
      var form_id = results.attr('id').replace(new RegExp('-form$'), '-results');
      results = $('.'+form_id);
    }
Severity: Minor
Found in resources/js/search.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function addRequest(...$names)
    {
        $request = $this->config['request'];

        // If names provided as an array.
Severity: Minor
Found in src/Search.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generateSessionName has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public static function generateSessionName($name, $class = '', $route_text = '', $route_parameters = [])
    {
        // Use the unique route as the session name.
        if (! empty($route_text)) {
            $name = str_replace(['[', ']', '::', ' '], ['', '-', '-', ''], $route_text);
Severity: Minor
Found in src/Search.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return $this;
Severity: Major
Found in src/Search.php - About 30 mins to fix

    The method setSearchEmpty has a boolean flag argument $config, which is a certain sign of a Single Responsibility Principle violation.
    Open

        private function setSearchEmpty($config = false)
    Severity: Minor
    Found in src/Search.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method setSearchInput has a boolean flag argument $config, which is a certain sign of a Single Responsibility Principle violation.
    Open

        private function setSearchInput($config = false)
    Severity: Minor
    Found in src/Search.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    Avoid too many return statements within this method.
    Open

            return $this;
    Severity: Major
    Found in src/Search.php - About 30 mins to fix

      Function getSearchInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getSearchInfo()
    {
        $total_columns = $this->checkColumns();
        $search_info = Arr::get($this->config, 'search_info', []);
        $tbody = Tag::tbody();
      Severity: Minor
      Found in src/Search.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function run($query)
    {
        $this->query = clone $query;

        // Run query.
      Severity: Minor
      Found in src/Search.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid unused private methods such as 'getHeader'.
      Open

          private function getHeader()
    {
        return '';
    }
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Avoid unused private methods such as 'getSearchFooter'.
      Open

          private function getSearchFooter()
    {
        $total_columns = $this->checkColumns();
        $tbody = Tag::tbody();
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Avoid unused private methods such as 'getSearchEmpty'.
      Open

          private function getSearchEmpty()
    {
        $search_empty = Arr::get($this->config, 'search_empty', []);
        $tbody = Tag::tbody();
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Avoid using empty try-catch blocks in parseModelName.
      Open

              } catch (\Exception $exception) {
        }
      Severity: Minor
      Found in src/Search.php by phpmd

      EmptyCatchBlock

      Since: 2.7.0

      Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.

      Example

      class Foo {

  public function bar()
  {
      try {
          // ...
      } catch (Exception $e) {} // empty catch block
  }
}

      Source https://phpmd.org/rules/design.html#emptycatchblock

      Avoid unused private methods such as 'setName'.
      Open

          private function setName($name)
    {
        $this->config['name'] = $name;
        $this->form_id = $name;
    }
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Avoid unused private methods such as 'getSearchHeader'.
      Open

          private function getSearchHeader()
    {
        $total_columns = $this->checkColumns();
        $search_header = Arr::get($this->config, 'search_header', []);
        $thead = Tag::thead();
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Avoid unused private methods such as 'setSearchEmpty'.
      Open

          private function setSearchEmpty($config = false)
    {
        // Turn off the the search empty option.
        if ($config === false) {
            Arr::set($this->config, 'search_empty', false);
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Avoid unused private methods such as 'setQuery'.
      Open

          private function setQuery($query)
    {
        $this->config['query'] = $query;
    }
      Severity: Minor
      Found in src/Search.php by phpmd

      UnusedPrivateMethod

      Since: 0.2

      Unused Private Method detects when a private method is declared but is unused.

      Example

      class Something
{
    private function foo() {} // unused
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

      Severity
      Category
      Status
      Source
      Language