Sign upLogin

hnhdigital-os/mysql-helper

View on GitHub
Star
app/Commands/RestoreCommand.php

Summary

Maintainability
A
1 hr
Test Coverage

Method runRestore has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    private function runRestore($profile, $connection, $sql_path, $database)
    {
        $this->line(' Source:');
        $this->info(sprintf(' %s', $sql_path));
        $this->line('');
Severity: Major
Found in app/Commands/RestoreCommand.php - About 2 hrs to fix

    Method handle has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

        public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
    Severity: Minor
    Found in app/Commands/RestoreCommand.php - About 1 hr to fix

      Function handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
      Severity: Minor
      Found in app/Commands/RestoreCommand.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function runRestore has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          private function runRestore($profile, $connection, $sql_path, $database)
    {
        $this->line(' Source:');
        $this->info(sprintf(' %s', $sql_path));
        $this->line('');
      Severity: Minor
      Found in app/Commands/RestoreCommand.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Wontfix

                      return 1;
      Severity: Major
      Found in app/Commands/RestoreCommand.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this->runRestore($profile, $connection, $sql_path, $database);
        Severity: Major
        Found in app/Commands/RestoreCommand.php - About 30 mins to fix

          Avoid assigning values to variables in if clauses and the like (line '84', column '19').
          Open

              public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
          Severity: Minor
          Found in app/Commands/RestoreCommand.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '55', column '19').
          Open

              public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
          Severity: Minor
          Found in app/Commands/RestoreCommand.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '64', column '19').
          Open

              public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
          Severity: Minor
          Found in app/Commands/RestoreCommand.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '73', column '19').
          Open

              public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
          Severity: Minor
          Found in app/Commands/RestoreCommand.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '89', column '14').
          Open

              public function handle()
    {
        if (!$this->checkInstalledPackages()) {
            return;
        }
          Severity: Minor
          Found in app/Commands/RestoreCommand.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              private function selectLocalConnection($profile)
    {
        $menu_options = [];

        foreach (array_keys(array_get($this->profiles, $profile.'.local', [])) as $name) {
          Severity: Major
          Found in app/Commands/RestoreCommand.php and 2 other locations - About 1 hr to fix
          app/Commands/BackupCommand.php on lines 128..141
          app/Commands/DisplayCommand.php on lines 176..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status