hnhdigital-os/php-linode-api

View on GitHub
src/endpoints/Nodebalancer.php

Summary

Maintainability
C
1 day
Test Coverage

Avoid using undefined variables such as '$node_balancer_id' which will lead to PHP notices.
Open

            'node_balancer_id' => $node_balancer_id,
Severity: Minor
Found in src/endpoints/Nodebalancer.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid unused local variables such as '$node_balancer_id'.
Open

            'node_balancer_id' => $node_balancer_id,
Severity: Minor
Found in src/endpoints/Nodebalancer.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace HnhDigital\LinodeApi;

/*
Severity: Major
Found in src/endpoints/Nodebalancer.php and 1 other location - About 1 day to fix
src/endpoints/Domain.php on lines 1..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 246.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line exceeds 120 characters; contains 121 characters
Open

     * Creates a NodeBalancer Config, which allows the NodeBalancer to accept traffic on a new port. You will need to add

Line exceeds 120 characters; contains 125 characters
Open

     * Deleting a NodeBalancer will also delete all associated Configs and Nodes, although the backend servers represented by

Line exceeds 120 characters; contains 122 characters
Open

     * the Nodes will not be changed or removed. Deleting a NodeBalancer will cause you to lose access to the IP Addresses

Line exceeds 120 characters; contains 121 characters
Open

     * Returns a paginated list of NodeBalancer Configs associated with this NodeBalancer. NodeBalancer Configs represent

Line exceeds 120 characters; contains 121 characters
Open

        return $this->apiSearch($this->endpoint.'/configs', ['class' => 'Node\Balancer\Config', 'parameters' => ['id']]);

There are no issues that match your filters.

Category
Status