hold-the-door/ravens

View on GitHub

Showing 4 of 4 total issues

Avoid excessively long variable names like $adapter_factory_config. Keep variable name length under 20.
Open

    private $adapter_factory_config;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $delivery_strategy_factory. Keep variable name length under 20.
Open

    private $delivery_strategy_factory;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $adapter_factory_config. Keep variable name length under 20.
Open

    public function __construct(array $adapter_factory_config)

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function initialize()
    {
        $amqp_channel = $this->channel->getAmqpChannel();

        $queue_options = [];
Severity: Minor
Found in src/Hodor/MessageQueue/Adapter/Amqp/DeliveryStrategy.php - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language