holderdeord/hdo-site

View on GitHub

Showing 302 of 302 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  _this.appendSlide = function (html, slideClassList, el) {
    if (!html) return;
    if (html.nodeType) {
      return _this._extendSwiperSlide(html).append()
    }
Severity: Major
Found in app/assets/javascripts/lib/idangerous.swiper-1.8.7.js and 1 other location - About 2 hrs to fix
app/assets/javascripts/lib/idangerous.swiper-1.8.7.js on lines 276..284

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method import_vote has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def import_vote(xvote)
        log_import xvote
        xvote.validate!

        vote = Vote.find_by_external_id xvote.external_id
Severity: Major
Found in lib/hdo/import/persister.rb - About 2 hrs to fix

    Function doCode has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        commandProto.doCode = function (chunk, postProcessing) {
    
            var hasTextBefore = /\S[ ]*$/.test(chunk.before);
            var hasTextAfter = /^[ ]*\S/.test(chunk.after);
    
    Severity: Minor
    Found in app/assets/javascripts/lib/pagedown/Markdown.Editor.js - About 2 hrs to fix

      Function next has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        next:function () {
                if (this.done) {
                    return this.EOF;
                }
                if (!this._input) this.done = true;
      Severity: Minor
      Found in app/assets/javascripts/lib/handlebars-v1.3.0.js - About 2 hrs to fix

        Function setupCarts has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                setupCarts: function () {
                    var toggleRow, promiseTemplate, propositionTemplate;
        
                    this.promiseCart = this.createCart($('.cart[data-type=promises]'));
                    this.propositionCart = this.createCart($('.cart[data-type=propositions]'));
        Severity: Minor
        Found in app/assets/javascripts/issueEditor.js - About 2 hrs to fix

          Similar blocks of code found in 20 locations. Consider refactoring.
          Open

            table: [{3:1,4:2,5:[1,3],8:4,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,11],22:[1,13],23:[1,14],25:[1,15]},{1:[3]},{5:[1,16],8:17,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,11],22:[1,13],23:[1,14],25:[1,15]},{1:[2,2]},{5:[2,9],14:[2,9],15:[2,9],16:[2,9],19:[2,9],20:[2,9],22:[2,9],23:[2,9],25:[2,9]},{4:20,6:18,7:19,8:4,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,21],20:[2,8],22:[1,13],23:[1,14],25:[1,15]},{4:20,6:22,7:19,8:4,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,21],20:[2,8],22:[1,13],23:[1,14],25:[1,15]},{5:[2,13],14:[2,13],15:[2,13],16:[2,13],19:[2,13],20:[2,13],22:[2,13],23:[2,13],25:[2,13]},{5:[2,14],14:[2,14],15:[2,14],16:[2,14],19:[2,14],20:[2,14],22:[2,14],23:[2,14],25:[2,14]},{5:[2,15],14:[2,15],15:[2,15],16:[2,15],19:[2,15],20:[2,15],22:[2,15],23:[2,15],25:[2,15]},{5:[2,16],14:[2,16],15:[2,16],16:[2,16],19:[2,16],20:[2,16],22:[2,16],23:[2,16],25:[2,16]},{17:23,21:24,30:25,40:[1,28],42:[1,27],43:26},{17:29,21:24,30:25,40:[1,28],42:[1,27],43:26},{17:30,21:24,30:25,40:[1,28],42:[1,27],43:26},{17:31,21:24,30:25,40:[1,28],42:[1,27],43:26},{21:33,26:32,32:[1,34],33:[1,35],40:[1,28],43:26},{1:[2,1]},{5:[2,10],14:[2,10],15:[2,10],16:[2,10],19:[2,10],20:[2,10],22:[2,10],23:[2,10],25:[2,10]},{10:36,20:[1,37]},{4:38,8:4,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,11],20:[2,7],22:[1,13],23:[1,14],25:[1,15]},{7:39,8:17,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,21],20:[2,6],22:[1,13],23:[1,14],25:[1,15]},{17:23,18:[1,40],21:24,30:25,40:[1,28],42:[1,27],43:26},{10:41,20:[1,37]},{18:[1,42]},{18:[2,43],24:[2,43],28:43,32:[2,43],33:[2,43],34:[2,43],35:[2,43],36:[2,43],40:[2,43],42:[2,43]},{18:[2,25],24:[2,25],36:[2,25]},{18:[2,38],24:[2,38],32:[2,38],33:[2,38],34:[2,38],35:[2,38],36:[2,38],40:[2,38],42:[2,38],44:[1,44]},{21:45,40:[1,28],43:26},{18:[2,40],24:[2,40],32:[2,40],33:[2,40],34:[2,40],35:[2,40],36:[2,40],40:[2,40],42:[2,40],44:[2,40]},{18:[1,46]},{18:[1,47]},{24:[1,48]},{18:[2,41],21:50,27:49,40:[1,28],43:26},{18:[2,34],40:[2,34]},{18:[2,35],40:[2,35]},{18:[2,36],40:[2,36]},{5:[2,11],14:[2,11],15:[2,11],16:[2,11],19:[2,11],20:[2,11],22:[2,11],23:[2,11],25:[2,11]},{21:51,40:[1,28],43:26},{8:17,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,11],20:[2,3],22:[1,13],23:[1,14],25:[1,15]},{4:52,8:4,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,11],20:[2,5],22:[1,13],23:[1,14],25:[1,15]},{14:[2,23],15:[2,23],16:[2,23],19:[2,23],20:[2,23],22:[2,23],23:[2,23],25:[2,23]},{5:[2,12],14:[2,12],15:[2,12],16:[2,12],19:[2,12],20:[2,12],22:[2,12],23:[2,12],25:[2,12]},{14:[2,18],15:[2,18],16:[2,18],19:[2,18],20:[2,18],22:[2,18],23:[2,18],25:[2,18]},{18:[2,45],21:56,24:[2,45],29:53,30:60,31:54,32:[1,57],33:[1,58],34:[1,59],35:[1,61],36:[2,45],37:55,38:62,39:63,40:[1,64],42:[1,27],43:26},{40:[1,65]},{18:[2,37],24:[2,37],32:[2,37],33:[2,37],34:[2,37],35:[2,37],36:[2,37],40:[2,37],42:[2,37]},{14:[2,17],15:[2,17],16:[2,17],19:[2,17],20:[2,17],22:[2,17],23:[2,17],25:[2,17]},{5:[2,20],14:[2,20],15:[2,20],16:[2,20],19:[2,20],20:[2,20],22:[2,20],23:[2,20],25:[2,20]},{5:[2,21],14:[2,21],15:[2,21],16:[2,21],19:[2,21],20:[2,21],22:[2,21],23:[2,21],25:[2,21]},{18:[1,66]},{18:[2,42]},{18:[1,67]},{8:17,9:5,11:6,12:7,13:8,14:[1,9],15:[1,10],16:[1,12],19:[1,11],20:[2,4],22:[1,13],23:[1,14],25:[1,15]},{18:[2,24],24:[2,24],36:[2,24]},{18:[2,44],24:[2,44],32:[2,44],33:[2,44],34:[2,44],35:[2,44],36:[2,44],40:[2,44],42:[2,44]},{18:[2,46],24:[2,46],36:[2,46]},{18:[2,26],24:[2,26],32:[2,26],33:[2,26],34:[2,26],35:[2,26],36:[2,26],40:[2,26],42:[2,26]},{18:[2,27],24:[2,27],32:[2,27],33:[2,27],34:[2,27],35:[2,27],36:[2,27],40:[2,27],42:[2,27]},{18:[2,28],24:[2,28],32:[2,28],33:[2,28],34:[2,28],35:[2,28],36:[2,28],40:[2,28],42:[2,28]},{18:[2,29],24:[2,29],32:[2,29],33:[2,29],34:[2,29],35:[2,29],36:[2,29],40:[2,29],42:[2,29]},{18:[2,30],24:[2,30],32:[2,30],33:[2,30],34:[2,30],35:[2,30],36:[2,30],40:[2,30],42:[2,30]},{17:68,21:24,30:25,40:[1,28],42:[1,27],43:26},{18:[2,32],24:[2,32],36:[2,32],39:69,40:[1,70]},{18:[2,47],24:[2,47],36:[2,47],40:[2,47]},{18:[2,40],24:[2,40],32:[2,40],33:[2,40],34:[2,40],35:[2,40],36:[2,40],40:[2,40],41:[1,71],42:[2,40],44:[2,40]},{18:[2,39],24:[2,39],32:[2,39],33:[2,39],34:[2,39],35:[2,39],36:[2,39],40:[2,39],42:[2,39],44:[2,39]},{5:[2,22],14:[2,22],15:[2,22],16:[2,22],19:[2,22],20:[2,22],22:[2,22],23:[2,22],25:[2,22]},{5:[2,19],14:[2,19],15:[2,19],16:[2,19],19:[2,19],20:[2,19],22:[2,19],23:[2,19],25:[2,19]},{36:[1,72]},{18:[2,48],24:[2,48],36:[2,48],40:[2,48]},{41:[1,71]},{21:56,30:60,31:73,32:[1,57],33:[1,58],34:[1,59],35:[1,61],40:[1,28],42:[1,27],43:26},{18:[2,31],24:[2,31],32:[2,31],33:[2,31],34:[2,31],35:[2,31],36:[2,31],40:[2,31],42:[2,31]},{18:[2,33],24:[2,33],36:[2,33],40:[2,33]}],
          Severity: Major
          Found in app/assets/javascripts/lib/handlebars-v1.3.0.js and 19 other locations - About 1 hr to fix
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868
          app/assets/javascripts/lib/handlebars-v1.3.0.js on lines 868..868

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method import_promise has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def import_promise(promise)
                  log_import promise
          
                  unless promise.valid?
                    @log.error "promise is not valid: #{promise.inspect}"
          Severity: Minor
          Found in lib/hdo/import/persister.rb - About 1 hr to fix

            Function appendModal has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                appendModal: function (modal) {
                  this.stack.push(modal);
            
                  var that = this;
            
            
            Severity: Minor
            Found in app/assets/javascripts/twitter/bootstrap/bootstrap-modalmanager.js - About 1 hr to fix

              Function doLinkOrImage has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  commandProto.doLinkOrImage = function (chunk, postProcessing, isImage) {
              
                      chunk.trimWhitespace();
                      chunk.findTags(/\s*!?\[/, /\][ ]?(?:\n[ ]*)?(\[.*?\])?/);
                      var background;
              Severity: Minor
              Found in app/assets/javascripts/lib/pagedown/Markdown.Editor.js - About 1 hr to fix

                Function init has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        init: function () {
                            this.setupTemplates();
                            this.renderForm();
                
                            HDO.markdownEditor();
                Severity: Minor
                Found in app/assets/javascripts/issueEditor.js - About 1 hr to fix

                  Method auto_title has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def auto_title
                      title = plain_body.gsub("\n", " ")
                  
                      TITLE_RULES.each do |rx, replacement|
                        title.sub!(rx, replacement)
                  Severity: Minor
                  Found in app/models/proposition.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method update_or_create_proposition_connection has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def update_or_create_proposition_connection(proposition_id, connections)
                        connections.each do |data|
                          existing = PropositionConnection.where(proposition_id: proposition_id, issue_id: @issue.id, vote_id: data[:vote_id]).first
                  
                          if data[:connected]
                  Severity: Minor
                  Found in lib/hdo/issue_updater.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method update_index_on_change_of has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                  Open

                          def update_index_on_change_of(*classes)
                            if classes.last.kind_of?(Hash)
                              opts = classes.pop
                            else
                              opts = {}
                  Severity: Minor
                  Found in lib/hdo/search/index.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function skipLines has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      Chunks.prototype.skipLines = function (nLinesBefore, nLinesAfter, findExtraNewlines) {
                  
                          if (nLinesBefore === undefined) {
                              nLinesBefore = 1;
                          }
                  Severity: Minor
                  Found in app/assets/javascripts/lib/pagedown/Markdown.Editor.js - About 1 hr to fix

                    Function show has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      , show: function () {
                          var $tip
                            , inside
                            , pos
                            , actualWidth
                    Severity: Minor
                    Found in app/assets/javascripts/twitter/bootstrap/bootstrap-tooltip.js - About 1 hr to fix

                      Function Editor has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          Markdown.Editor = function (markdownConverter, idPostfix, options) {
                              
                              options = options || {};
                      
                              if (typeof options.handler === "function") { //backwards compatible behavior
                      Severity: Minor
                      Found in app/assets/javascripts/lib/pagedown/Markdown.Editor.js - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    } else if (this.type === 'party') {
                                        path           = 'parties/:partyId/widget';
                                        params.partyId = el.getAttribute('data-party-id');
                                        params.count   = el.getAttribute('data-count');
                                        params.issues  = el.getAttribute('data-issue-ids');
                        Severity: Major
                        Found in app/assets/javascripts/widgets/widgets.js and 1 other location - About 1 hr to fix
                        app/assets/javascripts/widgets/widgets.js on lines 92..115

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 68.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    } else if (this.type === 'representative') {
                                        path                    = 'representatives/:representativeId/widget';
                                        params.representativeId = el.getAttribute('data-representative-id');
                                        params.issues           = el.getAttribute('data-issue-ids');
                                        params.count            = el.getAttribute('data-issue-count');
                        Severity: Major
                        Found in app/assets/javascripts/widgets/widgets.js and 1 other location - About 1 hr to fix
                        app/assets/javascripts/widgets/widgets.js on lines 97..115

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 68.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function balanceTags has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function balanceTags(html) {
                        
                                if (html == "")
                                    return "";
                        
                        
                        Severity: Minor
                        Found in app/assets/javascripts/lib/pagedown/Markdown.Sanitizer.js - About 1 hr to fix

                          Method generate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def self.generate
                                  categories = [
                                    'Arbeidsliv',
                                    'Arbeidsmiljø',
                                    'Arbeidsvilkår',
                          Severity: Minor
                          Found in lib/hdo/stats/agenda.rb - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language