Sign upLogin

holderdeord/hdo-site

View on GitHub
Star
lib/hdo/import/committee_membership_updater.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def update
        # 1. all input memberships reflect the current state and should be added
        # 2. if one intersects an existing membership in the same committee, we
        #    adjust it to reflect the new data.
        # 3. if an existing, current membership is not present in the new data, it is
Severity: Minor
Found in lib/hdo/import/committee_membership_updater.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status