holderdeord/hdo-site

View on GitHub
lib/hdo/search/facet_search.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File facet_search.rb has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Hdo
  module Search
    module FacetSearch
      extend ActiveSupport::Concern

Severity: Minor
Found in lib/hdo/search/facet_search.rb - About 3 hrs to fix

    Method fetch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def fetch
            payload = {}
            payload[:size] = size
    
            payload.merge! facets
    Severity: Minor
    Found in lib/hdo/search/facet_search.rb - About 1 hr to fix

      Method navigators has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def navigators
              data = response.response['aggregations']
      
              search_params.map do |param, opts|
                next if param == :page
      Severity: Minor
      Found in lib/hdo/search/facet_search.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def initialize(search, query, title, param, data)
      Severity: Minor
      Found in lib/hdo/search/facet_search.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status