Sign upLogin

holyketzer/activeadmin-audit

View on GitHub
Star

Showing 6 of 6 total issues

Method has_versions has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

        def has_versions(options = {})
          options[:also_include] ||= {}
          options[:skip] ||= []
          options[:skip] += options[:also_include].keys
          if respond_to?(:translated_attrs)
Severity: Minor
Found in lib/active_admin/audit/has_versions.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has_versions has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def has_versions(options = {})
          options[:also_include] ||= {}
          options[:skip] ||= []
          options[:skip] += options[:also_include].keys
          if respond_to?(:translated_attrs)
Severity: Major
Found in lib/active_admin/audit/has_versions.rb - About 2 hrs to fix

    Method diff has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def diff(other_snapshot)
        keys = (self.keys + other_snapshot.keys).uniq

        keys.each_with_object({}) do |key, diff|
          old_value = self[key]
    Severity: Minor
    Found in lib/active_admin/audit/version_snapshot.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method materialize_item has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def materialize_item(klass, attr, value)
        if (association = klass.reflect_on_all_associations.find { |a| [a.foreign_key, a.plural_name, a.name.to_s].include?(attr) })
          # attr is association in klass
          if value.is_a?(Hash)
            if value.size == 1 && value.keys.first.to_s == association.klass.primary_key.to_s
    Severity: Minor
    Found in lib/active_admin/audit/version_snapshot.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method pretty_version_attribute_value has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def pretty_version_attribute_value(attr, value)
      case value
      when Array
        Arbre::Context.new(context: self) do
          text_node attr.humanize.singularize
    Severity: Minor
    Found in lib/active_admin/versions_helper.rb - About 1 hr to fix

      Method versions_diff_classes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def versions_diff_classes(removed, added)
      if (added.present? && removed.present?) || (BOOLEAN_VALUES.include?(added) && BOOLEAN_VALUES.include?(removed))
        old_class = 'changed'
        new_class = old_class
      elsif added.present? || BOOLEAN_VALUES.include?(added)
      Severity: Minor
      Found in lib/active_admin/versions_helper.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language