honeybee/honeybee

View on GitHub
src/Model/Aggregate/AggregateRoot.php

Summary

Maintainability
D
2 days
Test Coverage

File AggregateRoot.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Honeybee\Model\Aggregate;

use Honeybee\Common\Error\AggregateRoot\AggregateRootError;
Severity: Minor
Found in src/Model/Aggregate/AggregateRoot.php - About 6 hrs to fix

    AggregateRoot has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AggregateRoot extends Entity implements AggregateRootInterface
    {
        /**
         * @var AggregateRootEventList $history
         */
    Severity: Minor
    Found in src/Model/Aggregate/AggregateRoot.php - About 2 hrs to fix

      Function applyEvent has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function applyEvent(AggregateRootEventInterface $event, $auto_commit = true)
          {
              $this->guardEventPreConditions($event);
              if (!$this->setValues($event->getData())) {
                  $errors = [];
      Severity: Minor
      Found in src/Model/Aggregate/AggregateRoot.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method applyEvent has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function applyEvent(AggregateRootEventInterface $event, $auto_commit = true)
          {
              $this->guardEventPreConditions($event);
              if (!$this->setValues($event->getData())) {
                  $errors = [];
      Severity: Minor
      Found in src/Model/Aggregate/AggregateRoot.php - About 1 hr to fix

        Method guardCommandPreConditions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function guardCommandPreConditions(AggregateRootCommandInterface $command)
            {
                if ($this->getHistory()->isEmpty()) {
                    throw new HistoryEmptyError(
                        sprintf(
        Severity: Minor
        Found in src/Model/Aggregate/AggregateRoot.php - About 1 hr to fix

          Method processEmbeddedEntityCommand has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function processEmbeddedEntityCommand(CommandInterface $command, array $custom_event_state = [])
              {
                  $event_class = $command->getEventClass();
                  $attribute_name = $command->getParentAttributeName();
          
          
          Severity: Minor
          Found in src/Model/Aggregate/AggregateRoot.php - About 1 hr to fix

            Method createInitialData has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function createInitialData(
                    CreateAggregateRootCommand $create_command,
                    StateMachineInterface $state_machine
                ) {
                    $type = $this->getType();
            Severity: Minor
            Found in src/Model/Aggregate/AggregateRoot.php - About 1 hr to fix

              Method proceedWorkflow has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function proceedWorkflow(ProceedWorkflowCommand $workflow_command, StateMachineInterface $state_machine)
                  {
                      $this->guardCommandPreConditions($workflow_command);
              
                      if ($workflow_command->getCurrentStateName() !== $this->getWorkflowState()) {
              Severity: Minor
              Found in src/Model/Aggregate/AggregateRoot.php - About 1 hr to fix

                Method guardEventPreConditions has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function guardEventPreConditions(AggregateRootEventInterface $event)
                    {
                        if (!$event instanceof AggregateRootCreatedEvent
                            && $this->getIdentifier() !== $event->getAggregateRootIdentifier()
                        ) {
                Severity: Minor
                Found in src/Model/Aggregate/AggregateRoot.php - About 1 hr to fix

                  Function reconstituteFrom has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function reconstituteFrom(AggregateRootEventList $history)
                      {
                          if (!$this->history->isEmpty()) {
                              throw new ReconstitutionError('Trying to reconstitute history on an already initialized aggregate-root.');
                          }
                  Severity: Minor
                  Found in src/Model/Aggregate/AggregateRoot.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function processEmbeddedEntityCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function processEmbeddedEntityCommand(CommandInterface $command, array $custom_event_state = [])
                      {
                          $event_class = $command->getEventClass();
                          $attribute_name = $command->getParentAttributeName();
                  
                  
                  Severity: Minor
                  Found in src/Model/Aggregate/AggregateRoot.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              foreach ($this->getValidationResults() as $validation_result) {
                                  foreach ($validation_result->getViolatedRules() as $violated_rule) {
                                      foreach ($violated_rule->getIncidents() as $incident) {
                                          $errors[] = PHP_EOL . $validation_result->getSUbject()->getName() .
                                              ' - ' . $violated_rule->getName() .
                  Severity: Minor
                  Found in src/Model/Aggregate/AggregateRoot.php and 1 other location - About 45 mins to fix
                  src/Model/Aggregate/EmbeddedEntity.php on lines 72..80

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status