Sign upLogin

honeybee/honeybee

View on GitHub
Star
src/Projection/EventHandler/ProjectionUpdater.php

Summary

Maintainability
D
1 day
Test Coverage

File ProjectionUpdater.php has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Honeybee\Projection\EventHandler;

use Honeybee\Common\Error\RuntimeError;
Severity: Minor
Found in src/Projection/EventHandler/ProjectionUpdater.php - About 5 hrs to fix

    ProjectionUpdater has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ProjectionUpdater extends EventHandler
{
    protected $data_access_service;

    protected $projection_type_map;
    Severity: Minor
    Found in src/Projection/EventHandler/ProjectionUpdater.php - About 2 hrs to fix

      Method mirrorReferencedProjection has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function mirrorReferencedProjection(EntityReferenceInterface $projection)
    {
        $projection_type = $projection->getType();
        $mirrored_attribute_map = $projection_type->getAttributes()->filter(
            function (AttributeInterface $attribute) {
      Severity: Minor
      Found in src/Projection/EventHandler/ProjectionUpdater.php - About 1 hr to fix

        Method updateChildNodesAfterMovingParent has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function updateChildNodesAfterMovingParent(EntityInterface $parent)
    {
        // find all existing children of the moved parent node
        $projection_type = $parent->getType();
        $parent_identifier = $parent->getIdentifier();
        Severity: Minor
        Found in src/Projection/EventHandler/ProjectionUpdater.php - About 1 hr to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ConfigInterface $config,
        LoggerInterface $logger,
        DataAccessServiceInterface $data_access_service,
        ProjectionTypeMap $projection_type_map,
        AggregateRootTypeMap $aggregate_root_type_map,
          Severity: Minor
          Found in src/Projection/EventHandler/ProjectionUpdater.php - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $projection_type->createEntity($mirrored_values, $projection->getParent());
            Severity: Major
            Found in src/Projection/EventHandler/ProjectionUpdater.php - About 30 mins to fix

              Function handleEmbeddedEntityEvents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function handleEmbeddedEntityEvents(EntityInterface $projection, EmbeddedEntityEventList $events)
    {
        foreach ($events as $event) {
            if ($event instanceof EmbeddedEntityAddedEvent) {
                $this->onEmbeddedEntityAdded($projection, $event);
              Severity: Minor
              Found in src/Projection/EventHandler/ProjectionUpdater.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function onEmbeddedEntityModified has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function onEmbeddedEntityModified(EntityInterface $projection, EmbeddedEntityModifiedEvent $event)
    {
        $embedded_projection_attr = $projection->getType()->getAttribute($event->getParentAttributeName());
        $embedded_projection_type = $this->getEmbeddedEntityType($projection, $event);
              Severity: Minor
              Found in src/Projection/EventHandler/ProjectionUpdater.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function mirrorReferencedProjection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function mirrorReferencedProjection(EntityReferenceInterface $projection)
    {
        $projection_type = $projection->getType();
        $mirrored_attribute_map = $projection_type->getAttributes()->filter(
            function (AttributeInterface $attribute) {
              Severity: Minor
              Found in src/Projection/EventHandler/ProjectionUpdater.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function __construct(
        ConfigInterface $config,
        LoggerInterface $logger,
        DataAccessServiceInterface $data_access_service,
        ProjectionTypeMap $projection_type_map,
              Severity: Minor
              Found in src/Projection/EventHandler/ProjectionUpdater.php and 1 other location - About 45 mins to fix
              src/Projection/EventHandler/RelationProjectionUpdater.php on lines 37..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 95.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status