honeybee/trellis

View on GitHub

Showing 177 of 223 total issues

Entity has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Entity extends BaseObject implements EntityInterface, ValueChangedListenerInterface, JsonSerializable
{
    /**
     * Holds the entity's type.
     *
Severity: Minor
Found in src/Runtime/Entity/Entity.php - About 3 hrs to fix

    File ImageRule.php has 293 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Trellis\Runtime\Attribute\Image;
    
    use Exception;
    Severity: Minor
    Found in src/Runtime/Attribute/Image/ImageRule.php - About 3 hrs to fix

      Method execute has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function execute($value, EntityInterface $entity = null)
          {
              $default_timezone = new DateTimeZone(
                  $this->getOption(
                      self::OPTION_INTERNAL_TIMEZONE_NAME,
      Severity: Major
      Found in src/Runtime/Validator/Rule/Type/TimestampRule.php - About 2 hrs to fix

        File AssetRule.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        namespace Trellis\Runtime\Attribute\Asset;
        
        use Exception;
        Severity: Minor
        Found in src/Runtime/Attribute/Asset/AssetRule.php - About 2 hrs to fix

          Function createComplexValue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function createComplexValue(AttributeInterface $attribute, array $options = array())
              {
                  $values = array();
                  $value_holder = $attribute->createValueHolder();
                  $value_type = $value_holder->getValueType();
          Severity: Minor
          Found in src/Sham/DataGenerator.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File KeyValueListRule.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          namespace Trellis\Runtime\Validator\Rule\Type;
          
          use Trellis\Common\Error\InvalidConfigException;
          Severity: Minor
          Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 2 hrs to fix

            Collection has 23 functions (exceeds 20 allowed). Consider refactoring.
            Open

            abstract class Collection extends BaseObject implements CollectionInterface
            {
                /**
                 * An array of ListenerInterface that are notified upon collection changes.
                 * We can't (re)use our CollectionInterface stuff here as this is the lowest level of it's implementation.
            Severity: Minor
            Found in src/Common/Collection/Collection.php - About 2 hrs to fix

              Method execute has 62 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function execute($value, EntityInterface $entity = null)
                  {
                      if ($value === '') {
                          $value = $this->getOption(
                              AttributeInterface::OPTION_NULL_VALUE,
              Severity: Major
              Found in src/Runtime/Validator/Rule/Type/IntegerRule.php - About 2 hrs to fix

                Method buildNameMap has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected static function buildNameMap(Generator $generator)
                    {
                        return array_fill_keys(
                            [
                                'name',
                Severity: Major
                Found in src/Sham/TextGuesser.php - About 2 hrs to fix

                  Method execute has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function execute($values, EntityInterface $entity = null)
                      {
                          if (!is_array($values)) {
                              $this->throwError('non_array_value', [], IncidentInterface::CRITICAL);
                              return false;
                  Severity: Major
                  Found in src/Runtime/Attribute/IntegerList/IntegerListRule.php - About 2 hrs to fix

                    Function execute has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function execute($value, EntityInterface $entity = null)
                        {
                            $cast_to_array = $this->getOption(self::OPTION_CAST_TO_ARRAY, true);
                            if ((!$cast_to_array && !is_array($value)) || (!$cast_to_array && !$value instanceof Traversable)) {
                                $this->throwError('not_an_array');
                    Severity: Minor
                    Found in src/Runtime/Validator/Rule/Type/ListRule.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File Entity.php has 255 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    
                    namespace Trellis\Runtime\Entity;
                    
                    use Closure;
                    Severity: Minor
                    Found in src/Runtime/Entity/Entity.php - About 2 hrs to fix

                      Function fake has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function fake(EntityInterface $entity, array $options = array())
                          {
                              if (!empty($options[self::OPTION_LOCALE])) {
                                  $loc = $options[self::OPTION_LOCALE];
                                  if (!is_string($loc) || !preg_match('#[a-z]{2,6}_[A-Z]{2,6}#', $loc)) {
                      Severity: Minor
                      Found in src/Sham/DataGenerator.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getAttributeValueByPath has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static function getAttributeValueByPath(EntityInterface $entity, $value_path)
                          {
                              if (!mb_strpos($value_path, self::PATH_DELIMITER)) {
                                  return $entity->getValue($value_path);
                              }
                      Severity: Minor
                      Found in src/Runtime/Attribute/AttributeValuePath.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method execute has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function execute($value, EntityInterface $entity = null)
                          {
                              $cast_to_array = $this->getOption(self::OPTION_CAST_TO_ARRAY, true);
                              if ((!$cast_to_array && !is_array($value)) || (!$cast_to_array && !$value instanceof Traversable)) {
                                  $this->throwError('not_an_array');
                      Severity: Minor
                      Found in src/Runtime/Validator/Rule/Type/ListRule.php - About 2 hrs to fix

                        Method execute has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function execute($value, EntityInterface $entity = null)
                            {
                                if (!is_string($value)) {
                                    $this->throwError('non_string_value', [ 'value' => $value ], IncidentInterface::CRITICAL);
                                    return false;
                        Severity: Minor
                        Found in src/Runtime/Validator/Rule/Type/SpoofcheckerRule.php - About 1 hr to fix

                          Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function execute($value, EntityInterface $entity = null)
                              {
                                  if ($value === '') {
                                      $value = $this->getOption(
                                          AttributeInterface::OPTION_NULL_VALUE,
                          Severity: Minor
                          Found in src/Runtime/Validator/Rule/Type/IntegerRule.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function extractData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function extractData(BaseObjectInterface $object)
                              {
                                  $data = [ self::OBJECT_TYPE => get_class($object) ];
                                  $hidden_properties = $object->getHiddenProperties();
                          
                          
                          Severity: Minor
                          Found in src/Common/BaseObject.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function execute($value, EntityInterface $entity = null)
                              {
                                  if (!is_string($value)) {
                                      $this->throwError('non_string_value', [ 'value' => $value ], IncidentInterface::CRITICAL);
                                      return false;
                          Severity: Minor
                          Found in src/Runtime/Validator/Rule/Type/SpoofcheckerRule.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method createValueHolder has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function createValueHolder($apply_default_values = false)
                              {
                                  if (!$this->value_holder_implementor) {
                                      $implementor = $this->hasOption(self::OPTION_VALUE_HOLDER)
                                          ? $this->getOption(self::OPTION_VALUE_HOLDER)
                          Severity: Minor
                          Found in src/Runtime/Attribute/Attribute.php - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language