Sign upLogin

honeybee/trellis

View on GitHub
Star
src/Runtime/Attribute/Image/ImageRule.php

Summary

Maintainability
F
3 days
Test Coverage

File ImageRule.php has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Trellis\Runtime\Attribute\Image;

use Exception;
Severity: Minor
Found in src/Runtime/Attribute/Image/ImageRule.php - About 3 hrs to fix

    Method execute has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute($value, EntityInterface $entity = null)
    {
        try {
            if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
    Severity: Minor
    Found in src/Runtime/Attribute/Image/ImageRule.php - About 1 hr to fix

      Function getMetadataOptions has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getMetadataOptions()
    {
        $options = $this->getOptions();

        $value_type = self::METADATA_VALUE_TYPE_SCALAR;
      Severity: Minor
      Found in src/Runtime/Attribute/Image/ImageRule.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execute has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function execute($value, EntityInterface $entity = null)
    {
        try {
            if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
      Severity: Minor
      Found in src/Runtime/Attribute/Image/ImageRule.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getMetadataOptions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getMetadataOptions()
    {
        $options = $this->getOptions();

        $value_type = self::METADATA_VALUE_TYPE_SCALAR;
      Severity: Minor
      Found in src/Runtime/Attribute/Image/ImageRule.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/Runtime/Attribute/Image/ImageRule.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in src/Runtime/Attribute/Image/ImageRule.php - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                protected function getMetadataOptions()
    {
        $options = $this->getOptions();

        $value_type = self::METADATA_VALUE_TYPE_SCALAR;
            Severity: Major
            Found in src/Runtime/Attribute/Image/ImageRule.php and 1 other location - About 1 day to fix
            src/Runtime/Attribute/Asset/AssetRule.php on lines 304..343

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 304.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                protected $metadata_options = [
        self::OPTION_METADATA_ALLOWED_KEYS,
        self::OPTION_METADATA_ALLOWED_VALUES,
        self::OPTION_METADATA_ALLOWED_PAIRS,
        self::OPTION_METADATA_VALUE_TYPE,
            Severity: Major
            Found in src/Runtime/Attribute/Image/ImageRule.php and 1 other location - About 4 hrs to fix
            src/Runtime/Attribute/Asset/AssetRule.php on lines 214..246

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 175.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
                    $this->throwError('non_assoc_array', [ 'value' => $value ], IncidentInterface::CRITICAL);
                    return false;
                }
            Severity: Major
            Found in src/Runtime/Attribute/Image/ImageRule.php and 2 other locations - About 2 hrs to fix
            src/Runtime/Attribute/Asset/AssetRule.php on lines 251..262
            src/Runtime/Attribute/HtmlLink/HtmlLinkRule.php on lines 140..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 136.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status