Sign upLogin

honeybee/trellis

View on GitHub
Star
src/Runtime/Validator/Rule/Type/KeyValueListRule.php

Summary

Maintainability
D
2 days
Test Coverage

Function execute has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_array($value)) {
            $this->throwError('non_array_value', [], IncidentInterface::CRITICAL);
            return false;
Severity: Minor
Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_array($value)) {
            $this->throwError('non_array_value', [], IncidentInterface::CRITICAL);
            return false;
Severity: Major
Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 4 hrs to fix

    File KeyValueListRule.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Trellis\Runtime\Validator\Rule\Type;

use Trellis\Common\Error\InvalidConfigException;
    Severity: Minor
    Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 2 hrs to fix

      Function castArray has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function castArray($array)
    {
        $value_type = $this->getOption(self::OPTION_VALUE_TYPE, self::VALUE_TYPE_SCALAR);

        $casted = [];
      Severity: Minor
      Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method castArray has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function castArray($array)
    {
        $value_type = $this->getOption(self::OPTION_VALUE_TYPE, self::VALUE_TYPE_SCALAR);

        $casted = [];
      Severity: Minor
      Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return false;
        Severity: Major
        Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return false;
          Severity: Major
          Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return false;
              Severity: Major
              Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return false;
                Severity: Major
                Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php - About 30 mins to fix

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      protected function getIntegerOptions()
    {
        $integer_options = $this->getOptions();

        if (array_key_exists(self::OPTION_MIN_INTEGER_VALUE, $integer_options)) {
                  Severity: Major
                  Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php and 3 other locations - About 45 mins to fix
                  src/Runtime/Validator/Rule/Type/KeyValueListRule.php on lines 330..343
                  src/Runtime/Validator/Rule/Type/ScalarRule.php on lines 100..113
                  src/Runtime/Validator/Rule/Type/ScalarRule.php on lines 115..127

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                      protected function getFloatOptions()
    {
        $float_options = $this->getOptions();

        if (array_key_exists(self::OPTION_MIN_FLOAT_VALUE, $float_options)) {
                  Severity: Major
                  Found in src/Runtime/Validator/Rule/Type/KeyValueListRule.php and 3 other locations - About 45 mins to fix
                  src/Runtime/Validator/Rule/Type/KeyValueListRule.php on lines 345..357
                  src/Runtime/Validator/Rule/Type/ScalarRule.php on lines 100..113
                  src/Runtime/Validator/Rule/Type/ScalarRule.php on lines 115..127

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status