hongaar/bandersnatch

View on GitHub
src/prompter.ts

Summary

Maintainability
B
6 hrs
Test Coverage
C
75%

Function getQuestions has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private getQuestions(args: T) {
    // If we need to prompt for things, fill questions array
    return this.baseArgs.reduce((questions, arg) => {
      const name = arg.getName();
      const defaultValue = arg.getDefault();
Severity: Major
Found in src/prompter.ts - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

          if (isPromptable && (!presentInArgs || isDefault)) {
            // Detect the type of question we need to ask
            switch (true) {
              case typeof arg.getChoices() !== "undefined" &&
                (arg.getType() === "array" || Array.isArray(defaultValue)):
    Severity: Major
    Found in src/prompter.ts - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                case typeof arg.getChoices() !== "undefined":
                  // Use list question type
                  questions.push({
                    name,
                    type: "autocomplete",
      Severity: Major
      Found in src/prompter.ts and 1 other location - About 1 hr to fix
      src/prompter.ts on lines 86..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                case typeof arg.getChoices() !== "undefined" &&
                  (arg.getType() === "array" || Array.isArray(defaultValue)):
                  // Use checkbox question type
                  questions.push({
                    name,
      Severity: Major
      Found in src/prompter.ts and 1 other location - About 1 hr to fix
      src/prompter.ts on lines 99..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status